Implement cast support for ubyte

Author: juntyr

quaddtype/numpy_quaddtype/src/casts.cpp

@@ -184,6 +184,20 @@ to_quad<npy_byte>(npy_byte x, QuadBackendType backend)
     return result;
 }
 
+template <>
+inline quad_value
+to_quad<npy_ubyte>(npy_ubyte x, QuadBackendType backend)
+{
+    quad_value result;
+    if (backend == BACKEND_SLEEF) {
+        result.sleef_value = Sleef_cast_from_uint64q1(x);
+    }
+    else {
+        result.longdouble_value = (long double)x;
+    }
+    return result;
+}
+
 template <>
 inline quad_value
 to_quad<npy_short>(npy_short x, QuadBackendType backend)
@@ -447,6 +461,18 @@ from_quad<npy_byte>(quad_value x, QuadBackendType backend)
     }
 }
 
+template <>
+inline npy_ubyte
+from_quad<npy_ubyte>(quad_value x, QuadBackendType backend)
+{
+    if (backend == BACKEND_SLEEF) {
+        return (npy_ubyte)Sleef_cast_to_int64q1(x.sleef_value);
+    }
+    else {
+        return (npy_ubyte)x.longdouble_value;
+    }
+}
+
 template <>
 inline npy_short
 from_quad<npy_short>(quad_value x, QuadBackendType backend)
@@ -741,6 +767,7 @@ init_casts_internal(void)
 
     add_cast_to<npy_bool>(&PyArray_BoolDType);
     add_cast_to<npy_byte>(&PyArray_ByteDType);
+    add_cast_to<npy_ubyte>(&PyArray_ByteDType);
     add_cast_to<npy_short>(&PyArray_ShortDType);
     add_cast_to<npy_ushort>(&PyArray_UShortDType);
     add_cast_to<npy_int>(&PyArray_IntDType);
@@ -755,6 +782,7 @@ init_casts_internal(void)
 
     add_cast_from<npy_bool>(&PyArray_BoolDType);
     add_cast_from<npy_byte>(&PyArray_ByteDType);
+    add_cast_from<npy_ubyte>(&PyArray_ByteDType);
     add_cast_from<npy_short>(&PyArray_ShortDType);
     add_cast_from<npy_ushort>(&PyArray_UShortDType);
     add_cast_from<npy_int>(&PyArray_IntDType);

quaddtype/tests/test_quaddtype.py

@@ -39,6 +39,19 @@ def test_finfo_int_constant(name, value):
     assert getattr(numpy_quaddtype, name) == value
 
 
+@pytest.mark.parametrize("dtype", ["bool", "byte", "int8", "ubyte", "uint8", "short", "int16", "ushort", "uint16", "int", "int32", "uint", "uint32", "long", "ulong", "longlong", "int64", "ulonglong", "uint64", "half", "float16", "float", "float32", "double", "float64", "longdouble"])
+def test_astype(dtype):
+    if dtype in ("half", "float16"):
+        pytest.xfail(f"{dtype} astype not yet supported")
+
+    orig = np.array(1, dtype=dtype)
+    quad = orig.astype(QuadPrecDType, casting="safe")
+    back = quad.astype(dtype, casting="unsafe")
+
+    assert quad == 1
+    assert back == orig
+
+
 def test_basic_equality():
     assert QuadPrecision("12") == QuadPrecision(
         "12.0") == QuadPrecision("12.00")