BUG: fix reference leaks and null dereferences across the extension

Author: SwayamInSync

src/csrc/casts.cpp

@@ -15,6 +15,7 @@ extern "C" {
 }
 #include <cstring>
 #include <cstdlib>
+#include <new>
 #include <type_traits>
 #include "sleef.h"
 #include "sleefquad.h"
@@ -1828,7 +1829,7 @@ init_casts(void)
     try {
         return init_casts_internal();
     }
-    catch (int e) {
+    catch (const std::bad_alloc &) {
         PyErr_NoMemory();
         return nullptr;
     }

src/csrc/dtype.c

@@ -628,8 +628,7 @@ QuadPrecDType_new(PyTypeObject *NPY_UNUSED(cls), PyObject *args, PyObject *kwds)
         return NULL;
     }
 
-    return (PyObject *)quadprec_discover_descriptor_from_pyobject(
-            &QuadPrecDType, (PyObject *)QuadPrecision_raw_new(backend));
+    return (PyObject *)new_quaddtype_instance(backend);
 }
 
 static PyObject *
@@ -707,10 +706,12 @@ init_quadprec_dtype(void)
     ((PyTypeObject *)&QuadPrecDType)->tp_base = &PyArrayDescr_Type;
 
     if (PyType_Ready((PyTypeObject *)&QuadPrecDType) < 0) {
+        free_casts();
         return -1;
     }
 
     if (PyArrayInitDTypeMeta_FromSpec(&QuadPrecDType, &QuadPrecDType_DTypeSpec) < 0) {
+        free_casts();
         return -1;
     }
 

src/csrc/lock.c

@@ -6,12 +6,14 @@ PyThread_type_lock sleef_lock = NULL;
 PyMutex sleef_lock = {0};
 #endif
 
-void init_sleef_locks(void)
+int init_sleef_locks(void)
 {
 #if PY_VERSION_HEX < 0x30d00b3
     sleef_lock = PyThread_allocate_lock();
     if (!sleef_lock) {
         PyErr_NoMemory();
+        return -1;
     }
 #endif
+    return 0;
 }

src/csrc/quaddtype_main.c

@@ -102,18 +102,19 @@ PyInit__quaddtype_main(void)
     PyUnstable_Module_SetGIL(m, Py_MOD_GIL_NOT_USED);
 #endif
 
-    init_sleef_locks();
+    if (init_sleef_locks() < 0)
+        goto error;
 
     if (init_quadprecision_scalar() < 0)
         goto error;
 
-    if (PyModule_AddObject(m, "QuadPrecision", (PyObject *)&QuadPrecision_Type) < 0)
+    if (PyModule_AddObjectRef(m, "QuadPrecision", (PyObject *)&QuadPrecision_Type) < 0)
         goto error;
 
     if (init_quadprec_dtype() < 0)
         goto error;
 
-    if (PyModule_AddObject(m, "QuadPrecDType", (PyObject *)&QuadPrecDType) < 0)
+    if (PyModule_AddObjectRef(m, "QuadPrecDType", (PyObject *)&QuadPrecDType) < 0)
         goto error;
 
     if (init_quad_umath() < 0) {

src/csrc/scalar.c

@@ -200,6 +200,10 @@ QuadPrecision_from_object(PyObject *value, QuadBackendType backend)
     }
     else if (PyUnicode_Check(value)) {
         const char *s = PyUnicode_AsUTF8(value);
+        if (s == NULL) {
+            Py_DECREF(self);
+            return NULL;
+        }
         char *endptr = NULL;
         int err = NumPyOS_ascii_strtoq(s, backend, &self->value, &endptr);
         if (err < 0) {
@@ -248,6 +252,9 @@ QuadPrecision_from_object(PyObject *value, QuadBackendType backend)
         QuadPrecisionObject *quad_obj = (QuadPrecisionObject *)value;
         // create a new one with the same backend
         QuadPrecisionObject *self = QuadPrecision_raw_new(quad_obj->backend);
+        if (self == NULL) {
+            return NULL;
+        }
         if (quad_obj->backend == BACKEND_SLEEF) {
             self->value.sleef_value = quad_obj->value.sleef_value;
         }
@@ -620,7 +627,10 @@ QuadPrecision_as_integer_ratio(QuadPrecisionObject *self, PyObject *Py_UNUSED(ig
     }
 
     Py_DECREF(py_exp);
-    return PyTuple_Pack(2, numerator, denominator);
+    PyObject *ratio = PyTuple_Pack(2, numerator, denominator);
+    Py_DECREF(numerator);
+    Py_DECREF(denominator);
+    return ratio;
 }
 
 static int

src/csrc/scalar_ops.cpp

@@ -78,6 +78,7 @@ quad_binary_func(PyObject *op1, PyObject *op2)
         other_quad = (QuadPrecisionObject *)other;
         if (other_quad->backend != backend) {
             PyErr_SetString(PyExc_TypeError, "Cannot mix QuadPrecision backends");
+            Py_DECREF(other_quad);
             Py_DECREF(other);
             return NULL;
         }

src/include/lock.h

@@ -13,6 +13,6 @@ extern PyMutex sleef_lock;
 #define UNLOCK_SLEEF PyMutex_Unlock(&sleef_lock)
 #endif
 
-void init_sleef_locks(void);
+int init_sleef_locks(void);
 
 #endif // _QUADDTYPE_LOCK_H