Skip to content

Commit 135e969

Browse files
committed
Merge branch 'hotfix/0.17.3'
2 parents b44ce5d + cb590f2 commit 135e969

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [vNext]
88

9+
## [0.17.3] / 2019-02-27
10+
- Fixed documentation file generation
11+
- Fixed `CheckBuildProjectConfigurationsAttribute.Timeout` to be settable
12+
913
## [0.17.2] / 2019-02-24
1014
- Fixed parsing of changelog
1115

@@ -314,7 +318,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
314318
- Added CLT tasks for Git
315319
- Fixed background color in console output
316320

317-
[vNext]: https://github.com/nuke-build/common/compare/0.17.2...HEAD
321+
[vNext]: https://github.com/nuke-build/common/compare/0.17.3...HEAD
322+
[0.17.3]: https://github.com/nuke-build/common/compare/0.17.2...0.17.3
318323
[0.17.2]: https://github.com/nuke-build/common/compare/0.17.1...0.17.2
319324
[0.17.1]: https://github.com/nuke-build/common/compare/0.17.0...0.17.1
320325
[0.17.0]: https://github.com/nuke-build/common/compare/0.16.0...0.17.0

source/Directory.Build.props

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
<DefineConstants>$(DefineConstants);NETCORE</DefineConstants>
2727
</PropertyGroup>
2828

29-
<PropertyGroup Condition="'$(IsPackable)' == 'True'">
30-
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
29+
<PropertyGroup Condition="'$(IsPackable)' != 'False'">
30+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
3131
</PropertyGroup>
3232

3333
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">

source/Nuke.Common/Execution/CheckBuildProjectConfigurationsAttribute.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace Nuke.Common.Execution
1717
[AttributeUsage(AttributeTargets.Class)]
1818
public class CheckBuildProjectConfigurationsAttribute : Attribute, IPostLogoBuildExtension
1919
{
20-
public int TimeoutInMilliseconds { get; } = 500;
20+
public int TimeoutInMilliseconds { get; set; } = 500;
2121

2222
public void Execute(NukeBuild build, IReadOnlyCollection<ExecutableTarget> executableTargets)
2323
{

0 commit comments

Comments
 (0)