https://github.com/nucleic/kiwi/blob/main/kiwi/version.h
https://github.com/nucleic/kiwi/blob/main/CMakeLists.txt lines 11 - 18
The project has a version.h file that contains version information. CMakeLists parses this information. In version 1.5.0, we encountered a problem where the information in the source code and CMakeLists differed from the tag name.
I see this as a problem that could confuse the build and use of this library.
I suggest the following: after creating a tag, run ci/cd to validate the tag name and check it against the version in CMakeLists. Delete the version.h file as it is an important part of the code. If a version.h file is still needed, generate it from CMakeLists.
What do you think about this?
P.S. I can work on this when I have time.
https://github.com/nucleic/kiwi/blob/main/kiwi/version.h
https://github.com/nucleic/kiwi/blob/main/CMakeLists.txt lines 11 - 18
The project has a version.h file that contains version information. CMakeLists parses this information. In version 1.5.0, we encountered a problem where the information in the source code and CMakeLists differed from the tag name.
I see this as a problem that could confuse the build and use of this library.
I suggest the following: after creating a tag, run ci/cd to validate the tag name and check it against the version in CMakeLists. Delete the version.h file as it is an important part of the code. If a version.h file is still needed, generate it from CMakeLists.
What do you think about this?
P.S. I can work on this when I have time.