compiler: set SourceURL in NEF file

Close #3543.

Signed-off-by: Tural Devrishev <[email protected]>

Author: Tural Devrishev

cli/vm/cli_test.go

@@ -1129,7 +1129,7 @@ func TestRunWithHistoricState(t *testing.T) {
 	e.checkNextLine(t, "READY: loaded 36 instructions")
 	e.checkStack(t, []byte{1})
 	e.checkNextLine(t, "READY: loaded 36 instructions")
-	e.checkNextLineExact(t, "Error: at instruction 31 (SYSCALL): System.Contract.Call failed: called contract 0f825b050eb8ce9eaa82993e90615025ab798016 not found: key not found\n")
+	e.checkNextLineExact(t, "Error: at instruction 31 (SYSCALL): System.Contract.Call failed: called contract fc78291ebacd4dc1d4d6a16399ccb1fac8438d93 not found: key not found\n")
 }
 
 func TestEvents(t *testing.T) {

pkg/compiler/codegen.go

@@ -2508,6 +2508,12 @@ func codeGen(info *buildInfo) (*nef.File, *DebugInfo, error) {
 	if c.callTokens != nil {
 		f.Tokens = c.callTokens
 	}
+	if info.options != nil && info.options.SourceURL != "" {
+		if len(info.options.SourceURL) > nef.MaxSourceURLLength {
+			return nil, nil, errors.New("too long source URL")
+		}
+		f.Source = info.options.SourceURL
+	}
 	f.Checksum = f.CalculateChecksum()
 	return f, di, vm.IsScriptCorrect(buf, methods)
 }

pkg/compiler/compiler.go

@@ -2,7 +2,6 @@ package compiler
 
 import (
 	"encoding/json"
-	"errors"
 	"fmt"
 	"go/ast"
 	"go/parser"
@@ -267,13 +266,6 @@ func CompileAndSave(src string, o *Options) ([]byte, error) {
 	if err != nil {
 		return nil, fmt.Errorf("error while trying to compile smart contract file: %w", err)
 	}
-	if o.SourceURL != "" {
-		if len(o.SourceURL) > nef.MaxSourceURLLength {
-			return nil, errors.New("too long source URL")
-		}
-		f.Source = o.SourceURL
-		f.Checksum = f.CalculateChecksum()
-	}
 	bytes, err := f.Bytes()
 	if err != nil {
 		return nil, fmt.Errorf("error while serializing .nef file: %w", err)

pkg/neotest/compile.go

@@ -62,9 +62,6 @@ func CompileFile(t testing.TB, sender util.Uint160, srcPath string, configPath s
 	// nef.NewFile() cares about version a lot.
 	config.Version = "neotest"
 
-	ne, di, err := compiler.CompileWithOptions(srcPath, nil, nil)
-	require.NoError(t, err)
-
 	conf, err := smartcontract.ParseContractConfig(configPath)
 	require.NoError(t, err)
 
@@ -80,6 +77,8 @@ func CompileFile(t testing.TB, sender util.Uint160, srcPath string, configPath s
 	o.SafeMethods = conf.SafeMethods
 	o.Overloads = conf.Overloads
 	o.SourceURL = conf.SourceURL
+	ne, di, err := compiler.CompileWithOptions(srcPath, nil, o)
+	require.NoError(t, err)
 	m, err := compiler.CreateManifest(di, o)
 	require.NoError(t, err)
 

pkg/neotest/compile_test.go

@@ -26,3 +26,10 @@ func TestCompileFileCashedIdentifiers(t *testing.T) {
 	contract2 := CompileFile(t, sender, srcPath, configPath2)
 	require.NotEqual(t, contract1, contract2)
 }
+
+func TestAddSourceURLToNEF(t *testing.T) {
+	srcPath := "../../internal/basicchain/testdata/test_contract.go"
+	configPath := "../../internal/basicchain/testdata/test_contract.yml"
+	ctr := CompileFile(t, util.Uint160{}, srcPath, configPath)
+	require.NotEqual(t, "", ctr.NEF.Source)
+}