Merge pull request #52 from notificationapi-com/LNd7qf8p/2043-bug-in-auth-user

Not encode auth parameters in the header

Author: sahandseifi

package.json

@@ -1,6 +1,6 @@
 {
   "name": "notificationapi-js-client-sdk",
-  "version": "4.7.0",
+  "version": "4.7.1",
   "description": "NotificationAPI client-side library for JavaScript",
   "keywords": [
     "notificationapi",

src/__tests__/askForWebPushPermission.test.ts

@@ -15,13 +15,7 @@ const mockEndpoint = 'mockEndpoint';
 const mockKeys = { auth: 'auth', p256dh: 'p256dh' };
 const headers = {
   'content-type': 'application/json',
-  Authorization:
-    'Basic ' +
-    btoa(
-      `${encodeURIComponent(clientId)}:${encodeURIComponent(
-        userId
-      )}:${mockHashUserId}`
-    )
+  Authorization: 'Basic ' + btoa(`${clientId}:${userId}:${mockHashUserId}`)
 };
 const body = {
   webPushTokens: [

src/__tests__/identify.test.ts

@@ -66,8 +66,7 @@ describe('when identify is called', () => {
 
     it('with the right auth header', async () => {
       expect(fetchMock.mock.calls[0][1]['headers']['Authorization']).toEqual(
-        'Basic ' +
-          btoa(`${encodeURIComponent(clientId)}:${encodeURIComponent(userId)}:`)
+        'Basic ' + btoa(`${clientId}:${userId}:`)
       );
     });
 

src/index.ts

@@ -299,12 +299,7 @@ class NotificationAPIClient implements NotificationAPIClientInterface {
     )}/users/${encodeURIComponent(userId)}`;
 
     const authToken =
-      'Basic ' +
-      btoa(
-        `${encodeURIComponent(clientId)}:${encodeURIComponent(userId)}:${
-          userIdHash ?? ''
-        }`
-      );
+      'Basic ' + btoa(`${clientId}:${userId}:${userIdHash ?? ''}`);
 
     await fetch(url, {
       body: JSON.stringify(user),