Merge pull request #1680 from dannyzaken/danny-go-1.24

dannyzaken · web-flow · commit 2f4a6b4215d7 · 2025-08-25T12:15:00.000+03:00
updated go version to 1.24
diff --git a/.github/workflows/cli-tests.yml b/.github/workflows/cli-tests.yml
@@ -18,8 +18,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
-
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
       - name: Set environment variables
         run: |
           echo "PATH=$PATH:$HOME/go/bin" >> $GITHUB_ENV
diff --git a/.github/workflows/core-config-map-tests.yml b/.github/workflows/core-config-map-tests.yml
@@ -18,7 +18,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -13,7 +13,11 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"     
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
       - name: run lint
         id: run-build
         run: make lint || exit 1
diff --git a/.github/workflows/manual-build.yml b/.github/workflows/manual-build.yml
@@ -21,7 +21,11 @@ jobs:
           ref: ${{ github.event.inputs.branch }}
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Get Current Date
         id: date
diff --git a/.github/workflows/operator-olm-tests.yml b/.github/workflows/operator-olm-tests.yml
@@ -21,7 +21,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Run OLM Tests
         run: make test-olm
diff --git a/.github/workflows/operator-tests.yml b/.github/workflows/operator-tests.yml
@@ -18,7 +18,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Generate API
         run: make gen-api-fail-if-dirty --always-make
diff --git a/.github/workflows/run_admission_test.yml b/.github/workflows/run_admission_test.yml
@@ -20,7 +20,11 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: ./noobaa-operator/go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_cnpg_deployment_test.yml b/.github/workflows/run_cnpg_deployment_test.yml
@@ -19,7 +19,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Start Minikube
         id: minikube
diff --git a/.github/workflows/run_cosi_test.yaml b/.github/workflows/run_cosi_test.yaml
@@ -20,7 +20,11 @@ jobs:
       - name: Setup Go on runner
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_hac_test.yml b/.github/workflows/run_hac_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_azure_vault_test.yml b/.github/workflows/run_kms_azure_vault_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_dev_test.yml b/.github/workflows/run_kms_dev_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_ibm_kp_test.yml b/.github/workflows/run_kms_ibm_kp_test.yml
@@ -16,7 +16,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_kmip_test.yml b/.github/workflows/run_kms_kmip_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_rotate_test.yml b/.github/workflows/run_kms_rotate_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_tls_sa_test.yml b/.github/workflows/run_kms_tls_sa_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/run_kms_tls_token_test.yml b/.github/workflows/run_kms_tls_token_test.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -13,7 +13,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Get Current Date
         id: date
diff --git a/.github/workflows/upgrade-tests-workflow.yaml b/.github/workflows/upgrade-tests-workflow.yaml
@@ -23,7 +23,11 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version-file: go.mod
+          check-latest: true
+          cache: true
+          cache-dependency-path: |
+            **/go.sum
 
       - name: Set environment variables
         run: |
diff --git a/Makefile b/Makefile
@@ -24,7 +24,7 @@ else
 GOBIN=$(shell go env GOBIN)
 endif
 
-CONTROLLER_GEN_VERSION=v0.16.3
+CONTROLLER_GEN_VERSION=v0.18.0
 DEEPCOPY_GEN_VERSION=v0.29.3
 
 GO_LINUX ?= GOOS=linux GOARCH=amd64
diff --git a/deploy/crds/noobaa.io_backingstores.yaml b/deploy/crds/noobaa.io_backingstores.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.3
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: backingstores.noobaa.io
 spec:
   group: noobaa.io
diff --git a/deploy/crds/noobaa.io_bucketclasses.yaml b/deploy/crds/noobaa.io_bucketclasses.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.3
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: bucketclasses.noobaa.io
 spec:
   group: noobaa.io
@@ -127,6 +127,8 @@ spec:
                             BackingStores is an unordered list of backing store names.
                             The meaning of the list depends on the placement.
                           items:
+                            description: BackingStoreName is just a name-reference
+                              to a BackingStore
                             type: string
                           type: array
                         placement:
diff --git a/deploy/crds/noobaa.io_namespacestores.yaml b/deploy/crds/noobaa.io_namespacestores.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.3
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: namespacestores.noobaa.io
 spec:
   group: noobaa.io
diff --git a/deploy/crds/noobaa.io_noobaaaccounts.yaml b/deploy/crds/noobaa.io_noobaaaccounts.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.3
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: noobaaaccounts.noobaa.io
 spec:
   group: noobaa.io
diff --git a/deploy/crds/noobaa.io_noobaas.yaml b/deploy/crds/noobaa.io_noobaas.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.3
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: noobaas.noobaa.io
 spec:
   group: noobaa.io
diff --git a/go.mod b/go.mod
@@ -1,8 +1,6 @@
 module github.com/noobaa/noobaa-operator/v5
 
-go 1.23.0
-
-toolchain go1.23.4
+go 1.24
 
 replace (
 	// TODO: remove this replace once https://github.com/libopenstorage/secrets/pull/83 is merged
diff --git a/pkg/bundle/deploy.go b/pkg/bundle/deploy.go
