Skip to content

lifecycle | PutBucketLifecycleConfiguration - missing validations #8870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nadavMiz opened this issue Mar 17, 2025 · 0 comments · Fixed by #8914
Closed

lifecycle | PutBucketLifecycleConfiguration - missing validations #8870

nadavMiz opened this issue Mar 17, 2025 · 0 comments · Fixed by #8914
Assignees
@achouhan09

Comments

@nadavMiz
Copy link
Contributor

nadavMiz commented Mar 17, 2025 •
edited by romayalon
Loading

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

The following validations are missing from PutBucketLifecycleConfiguration:

  • according to AWS Date argument can only be at midnight UTC. in order to prevent time related errors this should be validated on policy level at PutBucketLifecycleConfiguration. AWS error:
An error occurred (InvalidArgument) when calling the PutBucketLifecycleConfiguration operation: 'Date' must be at midnight GMT
  • AbortIncompleteMultipartUpload can't be defined with either size or tags. error:
An error occurred (InvalidRequest) when calling the PutBucketLifecycleConfiguration operation: AbortIncompleteMultipartUpload cannot be specified with Tags.

  • expire rule: can't have day/date with ExpiredObjectDeleteMarker

  • AWS do not allow to specify multiple filter actions without And and on NooBaa it's allowed.

Actual behavior

operation succeed

Expected behavior

  1. operation should fail with errors:

Steps to reproduce

More information - Screenshots / Logs / Other output

https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleExpiration.html#API_LifecycleExpiration_Contents
@nadavMiz nadavMiz changed the title lifecycle | PutBucketLifecycleConfiguration - missing date validation lifecycle | PutBucketLifecycleConfiguration - missing validations Mar 18, 2025
@achouhan09 achouhan09 self-assigned this Mar 26, 2025
@achouhan09 achouhan09 mentioned this issue Mar 27, 2025
Merged
1 task
@shirady shirady mentioned this issue Apr 27, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achouhan09 achouhan09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added required validations in lifecycle rules achouhan09/noobaa-core
2 participants
@nadavMiz @achouhan09