Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | versioning | change POSIX to use file descriptors and linkat instead of paths and current safe_move #8820

Open
nadavMiz opened this issue Feb 24, 2025 · 0 comments
Labels

Comments

@nadavMiz
Copy link
Contributor

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

1.currently in posix we work with paths in order to move files. paths that might change by different threads / processes. to account for that we use safe_move_posix function that validates the source and destination files are the ones expected. but safe_move is not atomic and might not work properly in certain situations. also when safe_link does prevent the wrong file move, it causes a retry that could have been avoided by using file descriptors.
we should change it to work with FD and linkat similerly to how it works in POSIX

Expected behavior

Steps to reproduce

More information - Screenshots / Logs / Other output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant