Skip to content

Commit 5d64b67

Browse files
nomemoryCiobanu, Andrei-Nicolin (UK - EDC)
authored and
Ciobanu, Andrei-Nicolin (UK - EDC)
committed
Refactoring regex MockUnitString
1 parent 68e965e commit 5d64b67

File tree

5 files changed

+36
-27
lines changed

5 files changed

+36
-27
lines changed

Diff for: src/main/java/net/andreinc/mockneat/MockNeat.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import net.andreinc.mockneat.unit.objects.Factory;
3434
import net.andreinc.mockneat.unit.objects.Probabilities;
3535
import net.andreinc.mockneat.unit.objects.Reflect;
36-
import net.andreinc.mockneat.unit.regex.FromRegex;
36+
import net.andreinc.mockneat.unit.regex.Regex;
3737
import net.andreinc.mockneat.unit.seq.IntSeq;
3838
import net.andreinc.mockneat.unit.seq.LongSeq;
3939
import net.andreinc.mockneat.unit.text.*;
@@ -214,6 +214,8 @@ public <T, FT> Factory<T, FT> factory(Class<T> targetCls, Class<FT> factoryCls)
214214

215215
public Passwords passwords() { return this.rPasswords; }
216216

217+
public Regex regex(String regex) { return new Regex(regex); }
218+
217219
public <T> Probabilities<T> probabilites(Class<T> cls) { return new Probabilities<T>(this, cls); }
218220

219221
public <T> Reflect<T> reflect(Class<T> cls) { return new Reflect<>(cls);}
@@ -232,8 +234,6 @@ public java.util.Random getRandom() {
232234
return random;
233235
}
234236

235-
public FromRegex fromRegex(String regex) { return new FromRegex(regex); }
236-
237237
public <T> MockUnit<T> from(List<T> alphabet) {
238238
notEmpty(alphabet, ValidationUtils.INPUT_PARAMETER_NOT_NULL_OR_EMPTY, "alphabet");
239239
Supplier<T> supp = () -> {

Diff for: src/main/java/net/andreinc/mockneat/unit/regex/FromRegex.java renamed to src/main/java/net/andreinc/mockneat/unit/regex/Regex.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,12 @@
99
import static net.andreinc.mockneat.utils.ValidationUtils.validRegex;
1010
import static org.apache.commons.lang3.Validate.notNull;
1111

12-
/**
13-
* Created by andreinicolinciobanu on 25/03/17.
14-
*/
15-
public class FromRegex implements MockUnitString {
12+
//TODO add documentation
13+
public class Regex implements MockUnitString {
1614

1715
private String regex;
1816

19-
public FromRegex(String regex) {
17+
public Regex(String regex) {
2018
this.regex = regex;
2119
}
2220

Diff for: src/test/java/net/andreinc/mockneat/Constants.java

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public class Constants {
2626
public static final int EMAILS_CYCLES = 1000;
2727
public static final int FILES_CYCLES = 1000;
2828
public static final int FLOATS_CYCLES = 1000;
29+
public static final int REGEX_CYLCES = 1000;
2930
public static final int FMT_CYCLES = 1000;
3031
public static final int GENDERS_CYCLES = 1000;
3132
public static final int IBANS_CYCLES = 1000;

Diff for: src/test/java/net/andreinc/mockneat/unit/regex/FromRegex.java

-19
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
package net.andreinc.mockneat.unit.regex;
2+
3+
import org.junit.Test;
4+
5+
import static net.andreinc.mockneat.Constants.*;
6+
import static net.andreinc.mockneat.utils.LoopsUtils.loop;
7+
8+
public class RegexTest {
9+
10+
@Test(expected = NullPointerException.class)
11+
public void testNulLRegex() throws Exception {
12+
M.regex(null).val();
13+
}
14+
15+
@Test(expected = IllegalArgumentException.class)
16+
public void testInvalidRegex() throws Exception {
17+
M.regex("1{").val();
18+
}
19+
20+
@Test
21+
public void testFromRegex() throws Exception {
22+
loop(
23+
REGEX_CYLCES,
24+
MOCKS,
25+
m -> m.regex("[0-3]([a-c]|[e-g]{1,2})").val(),
26+
r -> r.matches("[0-3]([a-c]|[e-g]{1,2})")
27+
);
28+
}
29+
}

0 commit comments

Comments
 (0)