From 0f774b3dd52c146da4f6123290a2151a18cac58f Mon Sep 17 00:00:00 2001 From: Abinadi contreras Date: Tue, 15 Jul 2025 23:15:55 -0500 Subject: [PATCH 1/3] fix height dropdown --- packages/ui-components/src/Common/Select/index.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/Common/Select/index.module.css b/packages/ui-components/src/Common/Select/index.module.css index ed4f05e834bdb..51881e435ce64 100644 --- a/packages/ui-components/src/Common/Select/index.module.css +++ b/packages/ui-components/src/Common/Select/index.module.css @@ -61,7 +61,7 @@ } .dropdown { - @apply max-h-48 + @apply max-h-56 max-w-xs overflow-hidden overflow-y-auto From 7c4124885cac6affc1af706815d6db12259383e0 Mon Sep 17 00:00:00 2001 From: Abinadi contreras Date: Wed, 16 Jul 2025 17:48:43 -0500 Subject: [PATCH 2/3] fix(ui): Remove max-height from Select component dropdown in InstallationMethodDropdown --- .../Release/InstallationMethodDropdown.tsx | 1 + .../ui-components/src/Common/Select/index.tsx | 15 ++++++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx b/apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx index 831b5b6e480ee..b640912ee9de1 100644 --- a/apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx +++ b/apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx @@ -80,6 +80,7 @@ const InstallationMethodDropdown: FC = () => { ariaLabel={t('layouts.download.dropdown.platform')} onChange={platform => platform && release.setInstallMethod(platform)} className="min-w-28" + dropdownClassName="!max-h-none" inline={true} /> ); diff --git a/packages/ui-components/src/Common/Select/index.tsx b/packages/ui-components/src/Common/Select/index.tsx index bf534c014eee3..21df85fbcf1bf 100644 --- a/packages/ui-components/src/Common/Select/index.tsx +++ b/packages/ui-components/src/Common/Select/index.tsx @@ -39,6 +39,12 @@ type SelectProps = { inline?: boolean; onChange?: (value: T) => void; className?: string; + /** + * Allows passing custom CSS classes to the dropdown container element. + * This is useful for overriding default styles, such as adjusting `max-height`. + * The dropdown is rendered within a `Portal`. + */ + dropdownClassName?: string; ariaLabel?: string; loading?: boolean; disabled?: boolean; @@ -52,6 +58,7 @@ const Select = ({ inline, onChange, className, + dropdownClassName, ariaLabel, loading = false, disabled = false, @@ -166,9 +173,11 @@ const Select = ({ From f5869b6e4fcf7cef97d281b57448d962a585d617 Mon Sep 17 00:00:00 2001 From: Abinadi contreras Date: Wed, 16 Jul 2025 17:50:16 -0500 Subject: [PATCH 3/3] reverted changes from index.module.css --- packages/ui-components/src/Common/Select/index.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/Common/Select/index.module.css b/packages/ui-components/src/Common/Select/index.module.css index 51881e435ce64..ed4f05e834bdb 100644 --- a/packages/ui-components/src/Common/Select/index.module.css +++ b/packages/ui-components/src/Common/Select/index.module.css @@ -61,7 +61,7 @@ } .dropdown { - @apply max-h-56 + @apply max-h-48 max-w-xs overflow-hidden overflow-y-auto