-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix height dropdown #7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix height dropdown #7989
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK what should we do. Like if we add new entry in download select do we will increase size ?
I see that your PR is still in draft, so maybe you are not ready for comment yet, but anyway I will ask:
![]()
I wonder if the dropdown for Also your commit message would need to comply with https://github.com/nodejs/nodejs.org/blob/main/docs/code-style.md#commit-guidelines so, you would need to change to Finally, if you write |
Yes, it's because it shares the same class, and that also affects the versions dropdown menu. For it to only affect that specific element, it would have to be done with a 'prop' (property), and that would involve more changes. I just tried to make it as simple as possible and, seeing that it didn't significantly affect the versions list, I decided to submit it like that. I can adjust it so that everything displays correctly, even if more items are added to that list. |
Thanks for explaining! It's definitely an improvement from the current state. I'm just a user of this site, not a front-end developer or a site owner, so I think the site maintainers will need to give their opinion on the change. If you are ready for the PR to be reviewed, you can take it out of draft state. |
@MikeMcC399 is very important user opinions, thanks for your comment, I can test what you say to find the easiest way and expect approval. |
Thanks for your comment, I made some adjustments. |
This is an excellent improvement from a user perspective! 🎉 Thank you very much! |
@nodejs/nodejs-website what if we just made them all bigger |
That would be a step back in the evolution of this PR. I tried doing that and as I mentioned in #7989 (comment) the dropdown list for versions becomes very long and untidy, displaying additional end-of-life versions to download. This is off-topic for this PR, but I'll just mention it here: as an enhancement, the version list could display only supported versions by default and had a toggle to show all versions. |
Description
Adjust dropdown max-height from 48 to 56
#7969
Validation
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.