Repository navigation
Conversation
Passing an invalid argument type to fs.existsSync() now throws ERR_INVALID_ARG_TYPE instead of returning false. Other invalid paths, such as strings containing null bytes or non-file: URLs, continue to return false. This has been a runtime deprecation since v24.0.0. Refs: nodejs#55753 Refs: nodejs#55892 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
jasnell
commented
Nov 15, 2026
jasnell
commented
Nov 15, 2026
Co-authored-by: James M Snell <jasnell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67494 +/- ##
==========================================
- Coverage 90.67% 90.66% -0.01%
==========================================
Files 799 799
Lines 280245 280240 -5
Branches 54125 54118 -7
==========================================
- Hits 254100 254072 -28
- Misses 16280 16291 +11
- Partials 9865 9877 +12
🚀 New features to boost your workflow:
|
Collaborator
LiviaMedeiros
approved these changes
Nov 15, 2026
AugustinMauroy
approved these changes
Nov 16, 2026
Collaborator
richardlau
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing an invalid argument type to fs.existsSync() now throws ERR_INVALID_ARG_TYPE instead of returning false. Other invalid paths, such as strings containing null bytes or non-file: URLs, continue to return false.
This has been a runtime deprecation since v24.0.0.
Refs: #55753
Refs: #55892