deps: V8: cherry-pick 0cc9eb22c0b0

Original commit message:

    [api] Remove PromiseResolveAfterResolved and PromiseRejectAfterResolved

    These were previously deprecated in https://crrev.com/c/7774767

    Bug: 42213031
    Change-Id: I07b802b743bf052611f30a61c1132231df22f0bd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7897881
    Commit-Queue: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Olivier Flückiger <olivf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108040}

Refs: v8/v8@0cc9eb2

Author: bakkot

common.gypi

@@ -40,7 +40,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.22',
+    'v8_embedder_string': '-node.23',
 
     ##### V8 defaults for Node.js #####
 

deps/v8/include/v8-promise.h

@@ -158,10 +158,8 @@ using PromiseHook = void (*)(PromiseHookType type, Local<Promise> promise,
 enum PromiseRejectEvent {
   kPromiseRejectWithNoHandler = 0,
   kPromiseHandlerAddedAfterReject = 1,
-  kPromiseRejectAfterResolved V8_DEPRECATED("These events are being removed") =
-      2,
-  kPromiseResolveAfterResolved V8_DEPRECATED("These events are being removed") =
-      3,
+  kDeprecatedPromiseRejectAfterResolved V8_DEPRECATED("Removed event") = 2,
+  kDeprecatedPromiseResolveAfterResolved V8_DEPRECATED("Removed event") = 3,
 };
 
 class PromiseRejectMessage {

deps/v8/src/builtins/promise-abstract-operations.tq

@@ -12,12 +12,6 @@ extern transitioning runtime RejectPromise(
 extern transitioning runtime PromiseRevokeReject(
     implicit context: Context)(JSPromise): JSAny;
 
-extern transitioning runtime PromiseRejectAfterResolved(
-    implicit context: Context)(JSPromise, JSAny): JSAny;
-
-extern transitioning runtime PromiseResolveAfterResolved(
-    implicit context: Context)(JSPromise, JSAny): JSAny;
-
 extern transitioning runtime PromiseRejectEventFromStack(
     implicit context: Context)(JSPromise, JSAny): JSAny;
 }
@@ -406,7 +400,7 @@ transitioning javascript builtin PromiseCapabilityDefaultReject(
 
   // 4. If alreadyResolved.[[Value]] is true, return undefined.
   if (alreadyResolved == True) {
-    return runtime::PromiseRejectAfterResolved(promise, reason);
+    return Undefined;
   }
 
   // 5. Set alreadyResolved.[[Value]] to true.
@@ -434,7 +428,7 @@ transitioning javascript builtin PromiseCapabilityDefaultResolve(
 
   // 4. If alreadyResolved.[[Value]] is true, return undefined.
   if (alreadyResolved == True) {
-    return runtime::PromiseResolveAfterResolved(promise, resolution);
+    return Undefined;
   }
 
   // 5. Set alreadyResolved.[[Value]] to true.

deps/v8/src/d8/d8.cc

@@ -4575,13 +4575,6 @@ static void PrintMessageCallback(Local<Message> message, Local<Value> error) {
 
 void Shell::PromiseRejectCallback(v8::PromiseRejectMessage data) {
   if (options.ignore_unhandled_promises) return;
-  START_ALLOW_USE_DEPRECATED();
-  if (data.GetEvent() == v8::kPromiseRejectAfterResolved ||
-      data.GetEvent() == v8::kPromiseResolveAfterResolved) {
-    // Ignore reject/resolve after resolved.
-    return;
-  }
-  END_ALLOW_USE_DEPRECATED();
   v8::Local<v8::Promise> promise = data.GetPromise();
   v8::Isolate* isolate = v8::Isolate::GetCurrent();
   PerIsolateData* isolate_data = PerIsolateData::Get(isolate);

deps/v8/src/runtime/runtime-promise.cc

@@ -29,30 +29,6 @@ RUNTIME_FUNCTION(Runtime_PromiseRejectEventFromStack) {
   return ReadOnlyRoots(isolate).undefined_value();
 }
 
-RUNTIME_FUNCTION(Runtime_PromiseRejectAfterResolved) {
-  DCHECK_EQ(2, args.length());
-  HandleScope scope(isolate);
-  DirectHandle<JSPromise> promise = args.at<JSPromise>(0);
-  DirectHandle<Object> reason = args.at(1);
-  START_ALLOW_USE_DEPRECATED();
-  isolate->ReportPromiseReject(promise, reason,
-                               v8::kPromiseRejectAfterResolved);
-  END_ALLOW_USE_DEPRECATED();
-  return ReadOnlyRoots(isolate).undefined_value();
-}
-
-RUNTIME_FUNCTION(Runtime_PromiseResolveAfterResolved) {
-  DCHECK_EQ(2, args.length());
-  HandleScope scope(isolate);
-  DirectHandle<JSPromise> promise = args.at<JSPromise>(0);
-  DirectHandle<Object> resolution = args.at(1);
-  START_ALLOW_USE_DEPRECATED();
-  isolate->ReportPromiseReject(promise, resolution,
-                               v8::kPromiseResolveAfterResolved);
-  END_ALLOW_USE_DEPRECATED();
-  return ReadOnlyRoots(isolate).undefined_value();
-}
-
 RUNTIME_FUNCTION(Runtime_PromiseRevokeReject) {
   DCHECK_EQ(1, args.length());
   HandleScope scope(isolate);

deps/v8/src/runtime/runtime.h

@@ -441,8 +441,6 @@ constexpr bool CanTriggerGC(T... properties) {
   F(PromiseRevokeReject, 1, 1)           \
   F(RejectPromise, 3, 1)                 \
   F(ResolvePromise, 2, 1)                \
-  F(PromiseRejectAfterResolved, 2, 1)    \
-  F(PromiseResolveAfterResolved, 2, 1)   \
   F(ConstructSuppressedError, 3, 1)      \
   F(ConstructAggregateErrorHelper, 4, 1) \
   F(ConstructInternalAggregateErrorHelper, -1 /* <= 5*/, 1)

deps/v8/test/cctest/test-api.cc

@@ -16381,8 +16381,6 @@ TEST(ErrorLevelWarning) {
 v8::PromiseRejectEvent reject_event = v8::kPromiseRejectWithNoHandler;
 int promise_reject_counter = 0;
 int promise_revoke_counter = 0;
-int promise_reject_after_resolved_counter = 0;
-int promise_resolve_after_resolved_counter = 0;
 int promise_reject_msg_line_number = -1;
 int promise_reject_msg_column_number = -1;
 int promise_reject_line_number = -1;
@@ -16439,12 +16437,12 @@ void PromiseRejectCallback(v8::PromiseRejectMessage reject_message) {
       break;
     }
       START_ALLOW_USE_DEPRECATED();
-    case v8::kPromiseRejectAfterResolved: {
-      promise_reject_after_resolved_counter++;
+    case v8::kDeprecatedPromiseRejectAfterResolved: {
+      // Unreachable
       break;
     }
-    case v8::kPromiseResolveAfterResolved: {
-      promise_resolve_after_resolved_counter++;
+    case v8::kDeprecatedPromiseResolveAfterResolved: {
+      // Unreachable
       break;
     }
       END_ALLOW_USE_DEPRECATED();
@@ -16470,8 +16468,6 @@ v8::Local<v8::Value> RejectValue() {
 void ResetPromiseStates() {
   promise_reject_counter = 0;
   promise_revoke_counter = 0;
-  promise_reject_after_resolved_counter = 0;
-  promise_resolve_after_resolved_counter = 0;
   promise_reject_msg_line_number = -1;
   promise_reject_msg_column_number = -1;
   promise_reject_line_number = -1;
@@ -16710,8 +16706,6 @@ TEST(PromiseRejectCallback) {
   CHECK(!GetPromise("v0")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
-  CHECK_EQ(1, promise_reject_after_resolved_counter);
-  CHECK_EQ(0, promise_resolve_after_resolved_counter);
 
   ResetPromiseStates();
 
@@ -16728,8 +16722,6 @@ TEST(PromiseRejectCallback) {
   CHECK(!GetPromise("y0")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
-  CHECK_EQ(0, promise_reject_after_resolved_counter);
-  CHECK_EQ(1, promise_resolve_after_resolved_counter);
 
   // Test stack frames.
   env.isolate()->SetCaptureStackTraceForUncaughtExceptions(true);

deps/v8/test/inspector/isolate-data.cc

@@ -402,14 +402,6 @@ void InspectorIsolateData::PromiseRejectHandler(v8::PromiseRejectMessage data) {
                                  strlen(reason_str)));
     return;
 
-  } else {
-    START_ALLOW_USE_DEPRECATED();
-    if (data.GetEvent() == v8::kPromiseRejectAfterResolved ||
-        data.GetEvent() == v8::kPromiseResolveAfterResolved) {
-      // Ignore reject/resolve after resolved, like the blink handler.
-      return;
-    }
-    END_ALLOW_USE_DEPRECATED();
   }
 
   v8::Local<v8::Value> exception = data.GetValue();