fixup! lib: refactor internal webidl converters

Author: panva

test/parallel/test-internal-webidl-buffer-source.js

@@ -15,13 +15,19 @@ const TYPED_ARRAY_CTORS = [
   Float16Array, Float32Array, Float64Array,
   BigInt64Array, BigUint64Array,
 ];
-const hasGrowableSharedArrayBuffer = (() => {
+
+function createGrowableSharedArrayBufferView(Ctor) {
   try {
-    return new SharedArrayBuffer(0, { maxByteLength: 1 }).growable === true;
+    const buffer = new SharedArrayBuffer(0, { maxByteLength: 1 });
+    const view = new Ctor(buffer);
+    return view.buffer.growable === true ? view : undefined;
   } catch {
-    return false;
+    return undefined;
   }
-})();
+}
+
+const hasGrowableSharedArrayBufferViews =
+  createGrowableSharedArrayBufferView(Uint8Array) !== undefined;
 
 test('BufferSource accepts ArrayBuffer', () => {
   const ab = new ArrayBuffer(8);
@@ -167,11 +173,12 @@ test('BufferSource handles resizable-backed views with explicit options', () =>
 });
 
 test('BufferSource handles growable SAB-backed views with explicit options', {
-  skip: !hasGrowableSharedArrayBuffer,
+  skip: !hasGrowableSharedArrayBufferViews,
 }, () => {
   for (const Ctor of [DataView, ...TYPED_ARRAY_CTORS]) {
     {
-      const view = new Ctor(new SharedArrayBuffer(0, { maxByteLength: 1 }));
+      const view = createGrowableSharedArrayBufferView(Ctor);
+      assert.notStrictEqual(view, undefined);
       assert.throws(
         () => converters.BufferSource(view, {
           allowShared: true,
@@ -182,7 +189,8 @@ test('BufferSource handles growable SAB-backed views with explicit options', {
     }
 
     {
-      const view = new Ctor(new SharedArrayBuffer(0, { maxByteLength: 1 }));
+      const view = createGrowableSharedArrayBufferView(Ctor);
+      assert.notStrictEqual(view, undefined);
       assert.strictEqual(converters.BufferSource(view, {
         allowShared: true,
         allowResizable: true,

test/parallel/test-internal-webidl.js

@@ -12,13 +12,18 @@ const opts = {
   prefix: 'Prefix',
   context: 'Context',
 };
-const hasGrowableSharedArrayBuffer = (() => {
+function createGrowableSharedArrayBufferView() {
   try {
-    return new SharedArrayBuffer(0, { maxByteLength: 1 }).growable === true;
+    const buffer = new SharedArrayBuffer(4, { maxByteLength: 8 });
+    const view = new Uint8Array(buffer);
+    return view.buffer.growable === true ? view : undefined;
   } catch {
-    return false;
+    return undefined;
   }
-})();
+}
+
+const hasGrowableSharedArrayBufferView =
+  createGrowableSharedArrayBufferView() !== undefined;
 
 function assertInvalidArgType(fn) {
   assert.throws(fn, {
@@ -436,9 +441,8 @@ assert.throws(() => webidl.requiredArguments(1, 2, opts), {
   assert.strictEqual(converters.BufferSource(view, allowShared), view);
   assert.strictEqual(converters.Uint8Array(view, allowShared), view);
 
-  if (hasGrowableSharedArrayBuffer) {
-    const growable = new SharedArrayBuffer(4, { maxByteLength: 8 });
-    const growableView = new Uint8Array(growable);
+  if (hasGrowableSharedArrayBufferView) {
+    const growableView = createGrowableSharedArrayBufferView();
 
     assert.throws(() => converters.BufferSource(growableView, {
       __proto__: null,