fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

Author: panva

src/crypto/crypto_context.cc

@@ -2044,13 +2044,17 @@ void SecureContext::SetDHParam(const FunctionCallbackInfo<Value>& args) {
   }
 
 #if NCRYPTO_USE_OPENSSL3_PROVIDER
-  if (!SSL_CTX_set0_tmp_dh_pkey(sc->ctx_.get(), dh.release())) {
+  EVPKeyPointer dh_pkey(dh.release());
+  if (!SSL_CTX_set0_tmp_dh_pkey(sc->ctx_.get(), dh_pkey.get())) {
 #else
   if (!SSL_CTX_set_tmp_dh(sc->ctx_.get(), dh.get())) {
 #endif
     return THROW_ERR_CRYPTO_OPERATION_FAILED(
         env, "Error setting temp DH parameter");
   }
+#if NCRYPTO_USE_OPENSSL3_PROVIDER
+  dh_pkey.release();
+#endif
 }
 
 void SecureContext::SetMinProto(const FunctionCallbackInfo<Value>& args) {

src/crypto/crypto_dh.cc

@@ -99,15 +99,15 @@ void PutDhError(int reason) {
 #endif
 }
 
+#if defined(OPENSSL_IS_BORINGSSL) || !NCRYPTO_USE_OPENSSL3_PROVIDER
 void PutBnError(int reason) {
 #ifdef OPENSSL_IS_BORINGSSL
   OPENSSL_PUT_ERROR(BN, reason);
-#elif NCRYPTO_USE_OPENSSL3_PROVIDER
-  ERR_raise(ERR_LIB_BN, reason);
 #else
   ERR_put_error(ERR_LIB_BN, 0, reason, __FILE__, __LINE__);
 #endif
 }
+#endif
 
 void DiffieHellmanGroup(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);