fixup! lib: refactor internal webidl converters

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Author: panva

test/parallel/test-internal-webidl-buffer-source.js

@@ -15,6 +15,13 @@ const TYPED_ARRAY_CTORS = [
   Float16Array, Float32Array, Float64Array,
   BigInt64Array, BigUint64Array,
 ];
+const hasGrowableSharedArrayBuffer = (() => {
+  try {
+    return new SharedArrayBuffer(0, { maxByteLength: 1 }).growable === true;
+  } catch {
+    return false;
+  }
+})();
 
 test('BufferSource accepts ArrayBuffer', () => {
   const ab = new ArrayBuffer(8);
@@ -159,7 +166,9 @@ test('BufferSource handles resizable-backed views with explicit options', () =>
   }
 });
 
-test('BufferSource handles growable SAB-backed views with explicit options', () => {
+test('BufferSource handles growable SAB-backed views with explicit options', {
+  skip: !hasGrowableSharedArrayBuffer,
+}, () => {
   for (const Ctor of [DataView, ...TYPED_ARRAY_CTORS]) {
     {
       const view = new Ctor(new SharedArrayBuffer(0, { maxByteLength: 1 }));

test/parallel/test-internal-webidl.js

@@ -12,6 +12,13 @@ const opts = {
   prefix: 'Prefix',
   context: 'Context',
 };
+const hasGrowableSharedArrayBuffer = (() => {
+  try {
+    return new SharedArrayBuffer(0, { maxByteLength: 1 }).growable === true;
+  } catch {
+    return false;
+  }
+})();
 
 function assertInvalidArgType(fn) {
   assert.throws(fn, {
@@ -429,38 +436,40 @@ assert.throws(() => webidl.requiredArguments(1, 2, opts), {
   assert.strictEqual(converters.BufferSource(view, allowShared), view);
   assert.strictEqual(converters.Uint8Array(view, allowShared), view);
 
-  const growable = new SharedArrayBuffer(4, { maxByteLength: 8 });
-  const growableView = new Uint8Array(growable);
-
-  assert.throws(() => converters.BufferSource(growableView, {
-    __proto__: null,
-    ...opts,
-    allowShared: true,
-    allowResizable: false,
-  }), {
-    name: 'TypeError',
-    code: 'ERR_INVALID_ARG_TYPE',
-    message: 'Prefix: Context is backed by a growable ' +
-      'SharedArrayBuffer, which is not allowed.',
-  });
-  assert.throws(() => converters.Uint8Array(growableView, {
-    __proto__: null,
-    ...opts,
-    allowShared: true,
-  }), {
-    name: 'TypeError',
-    code: 'ERR_INVALID_ARG_TYPE',
-    message: 'Prefix: Context is backed by a growable ' +
-      'SharedArrayBuffer, which is not allowed.',
-  });
-  assert.strictEqual(converters.BufferSource(growableView, {
-    __proto__: null,
-    allowShared: true,
-    allowResizable: true,
-  }), growableView);
-  assert.strictEqual(converters.Uint8Array(growableView, {
-    __proto__: null,
-    allowShared: true,
-    allowResizable: true,
-  }), growableView);
+  if (hasGrowableSharedArrayBuffer) {
+    const growable = new SharedArrayBuffer(4, { maxByteLength: 8 });
+    const growableView = new Uint8Array(growable);
+
+    assert.throws(() => converters.BufferSource(growableView, {
+      __proto__: null,
+      ...opts,
+      allowShared: true,
+      allowResizable: false,
+    }), {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'Prefix: Context is backed by a growable ' +
+        'SharedArrayBuffer, which is not allowed.',
+    });
+    assert.throws(() => converters.Uint8Array(growableView, {
+      __proto__: null,
+      ...opts,
+      allowShared: true,
+    }), {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'Prefix: Context is backed by a growable ' +
+        'SharedArrayBuffer, which is not allowed.',
+    });
+    assert.strictEqual(converters.BufferSource(growableView, {
+      __proto__: null,
+      allowShared: true,
+      allowResizable: true,
+    }), growableView);
+    assert.strictEqual(converters.Uint8Array(growableView, {
+      __proto__: null,
+      allowShared: true,
+      allowResizable: true,
+    }), growableView);
+  }
 }

test/parallel/test-structuredClone-global.js

@@ -6,7 +6,7 @@ const assert = require('assert');
 const prefix = "Failed to execute 'structuredClone'";
 const key = 'transfer';
 const context = 'Options';
-const memberConverterError = `${prefix}: ${key} in ${context} can not be converted to sequence.`;
+const memberConverterError = `${prefix}: ${key} in ${context} cannot be converted to sequence.`;
 const dictionaryConverterError = `${prefix}: ${context} cannot be converted to a dictionary`;
 
 assert.throws(() => structuredClone(), { code: 'ERR_MISSING_ARGS' });