repl: use inspector over vm

Author: avivkeller

doc/api/cli.md

@@ -2068,14 +2068,6 @@ added: v21.2.0
 
 Disable exposition of [Navigator API][] on the global scope.
 
-### `--no-experimental-repl-await`
-
-<!-- YAML
-added: v16.6.0
--->
-
-Use this flag to disable top-level await in REPL.
-
 ### `--no-experimental-require-module`
 
 <!-- YAML
@@ -3850,7 +3842,6 @@ one is included in the list below.
 * `--no-async-context-frame`
 * `--no-deprecation`
 * `--no-experimental-global-navigator`
-* `--no-experimental-repl-await`
 * `--no-experimental-sqlite`
 * `--no-experimental-strip-types`
 * `--no-experimental-websocket`

doc/api/errors.md

@@ -768,12 +768,6 @@ An operation outside the bounds of a `Buffer` was attempted.
 An attempt has been made to create a `Buffer` larger than the maximum allowed
 size.
 
-<a id="ERR_CANNOT_WATCH_SIGINT"></a>
-
-### `ERR_CANNOT_WATCH_SIGINT`
-
-Node.js was unable to watch for the `SIGINT` signal.
-
 <a id="ERR_CHILD_CLOSED_BEFORE_REPLY"></a>
 
 ### `ERR_CHILD_CLOSED_BEFORE_REPLY`
@@ -2144,13 +2138,6 @@ An invalid `options.protocol` was passed to `http.request()`.
 Both `breakEvalOnSigint` and `eval` options were set in the [`REPL`][] config,
 which is not supported.
 
-<a id="ERR_INVALID_REPL_INPUT"></a>
-
-### `ERR_INVALID_REPL_INPUT`
-
-The input may not be used in the [`REPL`][]. The conditions under which this
-error is used are described in the [`REPL`][] documentation.
-
 <a id="ERR_INVALID_RETURN_PROPERTY"></a>
 
 ### `ERR_INVALID_RETURN_PROPERTY`

doc/api/repl.md

@@ -170,39 +170,6 @@ global or scoped variable, the input `fs` will be evaluated on-demand as
 > fs.createReadStream('./some/file');
 ```
 
-#### Global uncaught exceptions
-
-<!-- YAML
-changes:
-  - version: v12.3.0
-    pr-url: https://github.com/nodejs/node/pull/27151
-    description: The `'uncaughtException'` event is from now on triggered if the
-                 repl is used as standalone program.
--->
-
-The REPL uses the [`domain`][] module to catch all uncaught exceptions for that
-REPL session.
-
-This use of the [`domain`][] module in the REPL has these side effects:
-
-* Uncaught exceptions only emit the [`'uncaughtException'`][] event in the
-  standalone REPL. Adding a listener for this event in a REPL within
-  another Node.js program results in [`ERR_INVALID_REPL_INPUT`][].
-
-  ```js
-  const r = repl.start();
-
-  r.write('process.on("uncaughtException", () => console.log("Foobar"));\n');
-  // Output stream includes:
-  //   TypeError [ERR_INVALID_REPL_INPUT]: Listeners for `uncaughtException`
-  //   cannot be used in the REPL
-
-  r.close();
-  ```
-
-* Trying to use [`process.setUncaughtExceptionCaptureCallback()`][] throws
-  an [`ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE`][] error.
-
 #### Assignment of the `_` (underscore) variable
 
 <!-- YAML
@@ -242,6 +209,14 @@ Uncaught Error: foo
 
 #### `await` keyword
 
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/64034
+    description: The `--experimental-repl-await` flag was removed. Top-level
+                 `await` is always enabled and can no longer be disabled.
+-->
+
 Support for the `await` keyword is enabled at the top level.
 
 ```console
@@ -257,25 +232,6 @@ undefined
 undefined
 ```
 
-One known limitation of using the `await` keyword in the REPL is that
-it will invalidate the lexical scoping of the `const` keywords.
-
-For example:
-
-```console
-> const m = await Promise.resolve(123)
-undefined
-> m
-123
-> m = await Promise.resolve(234)
-234
-// redeclaring the constant does error
-> const m = await Promise.resolve(345)
-Uncaught SyntaxError: Identifier 'm' has already been declared
-```
-
-[`--no-experimental-repl-await`][] shall disable top-level await in REPL.
-
 ### Reverse-i-search
 
 <!-- YAML
@@ -1174,9 +1130,7 @@ Original code from <https://gist.github.com/TooTallNate/2053342>.
 [TTY keybindings]: readline.md#tty-keybindings
 [ZSH]: https://en.wikipedia.org/wiki/Z_shell
 [`'uncaughtException'`]: process.md#event-uncaughtexception
-[`--no-experimental-repl-await`]: cli.md#--no-experimental-repl-await
 [`ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE`]: errors.md#err_domain_cannot_set_uncaught_exception_capture
-[`ERR_INVALID_REPL_INPUT`]: errors.md#err_invalid_repl_input
 [`curl()`]: https://curl.haxx.se/docs/manpage.html
 [`domain`]: domain.md
 [`module.builtinModules`]: module.md#modulebuiltinmodules

doc/node-config-schema.json

@@ -244,10 +244,6 @@
               "type": "boolean",
               "description": "Print pending top-level await. If --require-module is true, evaluate asynchronous graphs loaded by `require()` but do not run the microtasks, in order to to find and print top-level await in the graph"
             },
-            "experimental-repl-await": {
-              "type": "boolean",
-              "description": "experimental await keyword support in REPL"
-            },
             "experimental-require-module": {
               "type": "boolean",
               "description": "Legacy alias for --require-module"

lib/internal/errors.js

@@ -1156,7 +1156,6 @@ E('ERR_BUFFER_OUT_OF_BOUNDS',
 E('ERR_BUFFER_TOO_LARGE',
   'Cannot create a Buffer larger than %s bytes',
   RangeError);
-E('ERR_CANNOT_WATCH_SIGINT', 'Cannot watch for SIGINT signals', Error);
 E('ERR_CHILD_CLOSED_BEFORE_REPLY',
   'Child closed before reply received', Error);
 E('ERR_CHILD_PROCESS_IPC_REQUIRED',
@@ -1543,7 +1542,6 @@ E('ERR_INVALID_PROTOCOL',
   TypeError);
 E('ERR_INVALID_REPL_EVAL_CONFIG',
   'Cannot specify both "breakEvalOnSigint" and "eval" for REPL', TypeError);
-E('ERR_INVALID_REPL_INPUT', '%s', TypeError);
 E('ERR_INVALID_RETURN_PROPERTY', (input, name, prop, value) => {
   return `Expected a valid ${input} to be returned for the "${prop}" from the` +
          ` "${name}" hook but got ${determineSpecificType(value)}.`;