Skip to content

Commit 3b21617

Browse files
committed
refactor: use super Close method
Use the super Close method instead of duplicating code
1 parent 89a5c17 commit 3b21617

2 files changed

Lines changed: 2 additions & 17 deletions

File tree

src/histogram.cc

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -555,25 +555,11 @@ void ELDHistogram::OnStop() {
555555
uv_prepare_stop(&prepare_handle_);
556556
}
557557

558-
void ELDHistogram::PrepareCloseCB(uv_handle_t* handle) {
559-
ELDHistogram* self = static_cast<ELDHistogram*>(handle->data);
560-
uv_close(reinterpret_cast<uv_handle_t*>(&self->check_handle_),
561-
HandleWrap::OnClose);
562-
}
563-
564558
void ELDHistogram::Close(Local<Value> close_callback) {
565559
if (IsHandleClosing()) return;
566560
OnStop();
567-
state_ = kClosing;
568-
569-
if (!close_callback.IsEmpty() && close_callback->IsFunction() &&
570-
!persistent().IsEmpty()) {
571-
object()
572-
->Set(env()->context(), env()->handle_onclose_symbol(), close_callback)
573-
.Check();
574-
}
575-
576-
uv_close(reinterpret_cast<uv_handle_t*>(&prepare_handle_), PrepareCloseCB);
561+
HandleWrap::Close(close_callback);
562+
uv_close(reinterpret_cast<uv_handle_t*>(&prepare_handle_), nullptr);
577563
}
578564

579565
void ELDHistogram::Start(const FunctionCallbackInfo<Value>& args) {

src/histogram.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ class ELDHistogram final : public HandleWrap, public HistogramImpl {
309309
private:
310310
static void PrepareCB(uv_prepare_t* handle);
311311
static void CheckCB(uv_check_t* handle);
312-
static void PrepareCloseCB(uv_handle_t* handle);
313312
void OnStart(StartFlags flags = StartFlags::RESET);
314313
void OnStop();
315314

0 commit comments

Comments
 (0)