Skip to content

Commit 0c7034f

Browse files
doc: fix article usage before vowel-sound acronyms
Several prose references to HTTP, HTTPS, SSL, HPE_HEADER_OVERFLOW and ECMAScript used the article "a" where the acronym starts with a vowel sound and should take "an". The rule is based on pronunciation, not spelling: HTTP is read "aitch-tee-tee-pee", SSL is read "ess-es-el", ECMAScript is read "ek-mah-script", and HPE is read "aitch-pee-ee" — all starting with a vowel sound. Affected files: * doc/api/crypto.md — "disable a SSL 3.0/TLS 1.0 vulnerability" * doc/api/http.md — five occurrences ("a HTTP '400 Bad Request'", "a HTTP '431 Request Header Fields Too Large'", "a HTTP/1.1 102 Processing message", two copies of "use a HTTP parser") plus two references to "a HPE_HEADER_OVERFLOW" * doc/api/http2.md — two code-sample comments reading "// Detects if it is a HTTPS request or HTTP/2" * doc/api/module.md — "compiles a CommonJS, a ECMAScript Module, or a TypeScript module" (only the middle article changes; the adjacent "a CommonJS" and "a TypeScript" are both correct) * doc/api/tls.md — two references to "part of a SSL/TLS handshake" in tlsSocket.getFinished() and tlsSocket.getPeerFinished() No behavior changes, documentation only. Signed-off-by: João Victor Oliveira <joao.oliveira@softtor.com.br> PR-URL: #62696 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
1 parent 4f4077a commit 0c7034f

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

doc/api/crypto.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6657,7 +6657,7 @@ See the [list of SSL OP Flags][] for details.
66576657
</tr>
66586658
<tr>
66596659
<td><code>SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS</code></td>
6660-
<td>Instructs OpenSSL to disable a SSL 3.0/TLS 1.0 vulnerability
6660+
<td>Instructs OpenSSL to disable an SSL 3.0/TLS 1.0 vulnerability
66616661
workaround added in OpenSSL 0.9.6d.</td>
66626662
</tr>
66636663
<tr>

doc/api/http.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1516,7 +1516,7 @@ changes:
15161516
- version: v12.0.0
15171517
pr-url: https://github.com/nodejs/node/pull/25605
15181518
description: The default behavior will return a 431 Request Header
1519-
Fields Too Large if a HPE_HEADER_OVERFLOW error occurs.
1519+
Fields Too Large if an HPE_HEADER_OVERFLOW error occurs.
15201520
- version: v9.4.0
15211521
pr-url: https://github.com/nodejs/node/pull/17672
15221522
description: The `rawPacket` is the current buffer that just parsed. Adding
@@ -1542,8 +1542,8 @@ This event is guaranteed to be passed an instance of the {net.Socket} class,
15421542
a subclass of {stream.Duplex}, unless the user specifies a socket
15431543
type other than {net.Socket}.
15441544

1545-
Default behavior is to try close the socket with a HTTP '400 Bad Request',
1546-
or a HTTP '431 Request Header Fields Too Large' in the case of a
1545+
Default behavior is to try close the socket with an HTTP '400 Bad Request',
1546+
or an HTTP '431 Request Header Fields Too Large' in the case of an
15471547
[`HPE_HEADER_OVERFLOW`][] error. If the socket is not writable or headers
15481548
of the current attached [`http.ServerResponse`][] has been sent, it is
15491549
immediately destroyed.
@@ -2735,7 +2735,7 @@ response.writeInformation(110, { 'X-Progress': '50%' });
27352735
added: v10.0.0
27362736
-->
27372737

2738-
Sends a HTTP/1.1 102 Processing message to the client, indicating that
2738+
Sends an HTTP/1.1 102 Processing message to the client, indicating that
27392739
the request body should be sent.
27402740

27412741
## Class: `http.IncomingMessage`
@@ -3734,7 +3734,7 @@ changes:
37343734
`readableHighWaterMark` and `writableHighWaterMark`. This affects
37353735
`highWaterMark` property of both `IncomingMessage` and `ServerResponse`.
37363736
**Default:** See [`stream.getDefaultHighWaterMark()`][].
3737-
* `insecureHTTPParser` {boolean} If set to `true`, it will use a HTTP parser
3737+
* `insecureHTTPParser` {boolean} If set to `true`, it will use an HTTP parser
37383738
with leniency flags enabled. Using the insecure parser should be avoided.
37393739
See [`--insecure-http-parser`][] for more information.
37403740
**Default:** `false`.
@@ -4045,7 +4045,7 @@ changes:
40454045
request to. **Default:** `'localhost'`.
40464046
* `hostname` {string} Alias for `host`. To support [`url.parse()`][],
40474047
`hostname` will be used if both `host` and `hostname` are specified.
4048-
* `insecureHTTPParser` {boolean} If set to `true`, it will use a HTTP parser
4048+
* `insecureHTTPParser` {boolean} If set to `true`, it will use an HTTP parser
40494049
with leniency flags enabled. Using the insecure parser should be avoided.
40504050
See [`--insecure-http-parser`][] for more information.
40514051
**Default:** `false`

doc/api/http2.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3976,7 +3976,7 @@ const server = createSecureServer(
39763976
).listen(8000);
39773977

39783978
function onRequest(req, res) {
3979-
// Detects if it is a HTTPS request or HTTP/2
3979+
// Detects if it is an HTTPS request or HTTP/2
39803980
const { socket: { alpnProtocol } } = req.httpVersion === '2.0' ?
39813981
req.stream.session : req;
39823982
res.writeHead(200, { 'content-type': 'application/json' });
@@ -4000,7 +4000,7 @@ const server = createSecureServer(
40004000
).listen(4443);
40014001

40024002
function onRequest(req, res) {
4003-
// Detects if it is a HTTPS request or HTTP/2
4003+
// Detects if it is an HTTPS request or HTTP/2
40044004
const { socket: { alpnProtocol } } = req.httpVersion === '2.0' ?
40054005
req.stream.session : req;
40064006
res.writeHead(200, { 'content-type': 'application/json' });

doc/api/module.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ changes:
366366
367367
The module compile cache can be enabled either using the [`module.enableCompileCache()`][]
368368
method or the [`NODE_COMPILE_CACHE=dir`][] environment variable. After it is enabled,
369-
whenever Node.js compiles a CommonJS, a ECMAScript Module, or a TypeScript module, it will
369+
whenever Node.js compiles a CommonJS, an ECMAScript Module, or a TypeScript module, it will
370370
use on-disk [V8 code cache][] persisted in the specified directory to speed up the compilation.
371371
This may slow down the first load of a module graph, but subsequent loads of the same module
372372
graph may get a significant speedup if the contents of the modules do not change.

doc/api/tls.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,7 +1212,7 @@ added: v9.9.0
12121212
-->
12131213

12141214
* Returns: {Buffer|undefined} The latest `Finished` message that has been
1215-
sent to the socket as part of a SSL/TLS handshake, or `undefined` if
1215+
sent to the socket as part of an SSL/TLS handshake, or `undefined` if
12161216
no `Finished` message has been sent yet.
12171217

12181218
As the `Finished` messages are message digests of the complete handshake
@@ -1355,7 +1355,7 @@ added: v9.9.0
13551355
-->
13561356

13571357
* Returns: {Buffer|undefined} The latest `Finished` message that is expected
1358-
or has actually been received from the socket as part of a SSL/TLS handshake,
1358+
or has actually been received from the socket as part of an SSL/TLS handshake,
13591359
or `undefined` if there is no `Finished` message so far.
13601360

13611361
As the `Finished` messages are message digests of the complete handshake

0 commit comments

Comments
 (0)