Fix window.shouldClose

raub · raub · commit f3d0b53b2b40 · 2023-11-07T22:39:24.000+04:00
diff --git a/js/window.js b/js/window.js
@@ -384,7 +384,7 @@ class Window extends EventEmitter {
 	}
 	
 	get shouldClose() { return glfw.windowShouldClose(this._window); }
-	set shouldClose(v) { glfw.setWindowShouldClose(v); }
+	set shouldClose(v) { glfw.setWindowShouldClose(this._window, v ? glfw.TRUE : glfw.FALSE); }
 	
 	get platformDevice() { return glfw.platformDevice(); }
 	get platformWindow() { return glfw.platformWindow(this._window); }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"author": "Luis Blanco <luisblanco1337@gmail.com>",
 	"name": "glfw-raub",
-	"version": "5.4.0",
+	"version": "5.4.1",
 	"description": "GLFW for Node.js",
 	"license": "MIT",
 	"main": "index.js",

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ class Window extends EventEmitter {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`get shouldClose() { return glfw.windowShouldClose(this._window); }`
`387`		`- set shouldClose(v) { glfw.setWindowShouldClose(v); }`
	`387`	`+ set shouldClose(v) { glfw.setWindowShouldClose(this._window, v ? glfw.TRUE : glfw.FALSE); }`
`388`	`388`
`389`	`389`	`get platformDevice() { return glfw.platformDevice(); }`
`390`	`390`	`get platformWindow() { return glfw.platformWindow(this._window); }`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"author": "Luis Blanco <[email protected]>",`
`3`	`3`	`"name": "glfw-raub",`
`4`		`- "version": "5.4.0",`
	`4`	`+ "version": "5.4.1",`
`5`	`5`	`"description": "GLFW for Node.js",`
`6`	`6`	`"license": "MIT",`
`7`	`7`	`"main": "index.js",`