Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-xfail test_compare_against_quark #1051

Open
renxida opened this issue Mar 7, 2025 · 0 comments
Open

Un-xfail test_compare_against_quark #1051

renxida opened this issue Mar 7, 2025 · 0 comments
Assignees

Comments

@renxida
Copy link
Contributor

renxida commented Mar 7, 2025

Had to xfail this test due to a very minor over-tolerance during IREE bump #1003

It doesn't look like much of a difference and only barely exceeds the tolerances. However, I don't know this test well enough to go in and increase the tolerances.


Failure log: https://gist.github.com/renxida/f1af75da6d9a82e662c6824fa1314ec7

Error message:
FAILED sharktank/tests/models/llama/quark_parity_test.py::QuarkParityTest::test_compare_against_quark - AssertionError: Tensor-likes are not equal!

Details:
Mismatched elements: 1 / 16384 (0.0%)
Greatest absolute difference: 0.00390625 at index (0, 1, 713)
Greatest relative difference: 0.004730224609375 at index (0, 1, 713)


Will assign to test author after #1003 merges to take a look at this and maybe increase the tolerance and re-enable if that's appropriate.

@renxida renxida changed the title Re-enable test_compare_against_quark Un-xfail test_compare_against_quark Mar 7, 2025
@renxida renxida self-assigned this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant