-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cubic spline option #4
Comments
I think the definitions for the admb functions are here: http://api.admb-project.org/vcubicspline_8cpp_source.html I'm curious how they differ from spline interpolations in r, like |
@iantaylor-NOAA , do you have any r code that mimics the cubic spline selectivity? We basically just need a function that reads in the params as input and outputs the selectivity patterns to use in the GUI (and hopefully, this need not rely on admb...) |
Also, any selectivity functions could be safely added here: https://github.com/r4ss/shiny_selex/blob/main/selex_fxns.R. They will not mess up the Shiny app. |
Thanks for moving this idea forward, @k-doering-NOAA. However, I believe that @roliveros-ramos was able to get a good match as part of his work on empirical selectivity with IATTC (which we really need to finish integrating into r4ss). @k-doering-NOAA, one of us could compare the results of code here to the results of an Stock Synthesis model with splines: |
Another potential resource is the spline function Neal uses in the GUI: https://github.com/nmfs-stock-synthesis/ssi/blob/master/src/ttk_spline.h |
Finally, the actual admb function to get the spline selectivity values is: http://api.admb-project.org/cspline_8cpp_source.html#l00037 (vcubic_spline_function eventually passes to this function) |
Thanks @iantaylor-NOAA for contributing this idea. cubic spline selectivity functionality would be really helpful (discussed in r4ss/r4ss#63 as well as r4ss/r4ss#48.
The text was updated successfully, but these errors were encountered: