Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up unit testing #14

Open
2 of 3 tasks
njallskarp opened this issue Jun 27, 2023 · 2 comments
Open
2 of 3 tasks

Set up unit testing #14

njallskarp opened this issue Jun 27, 2023 · 2 comments
Assignees
@Eysteinn-Orn @lsig
Labels
enhancement New feature or request

Comments

@njallskarp
Copy link
Owner

njallskarp commented Jun 27, 2023 •
edited by Eysteinn-Orn
Loading

Setup

Based on the research in previous ticket #15, set up unit testing for the project. This includes the following acceptance criteria

  • set up 1-2 unit tests for metrics file
  • can run unit tests locally
  • unit tests run on all commits and failed tests block merges
@njallskarp njallskarp added the enhancement New feature or request label Jun 27, 2023
@Eysteinn-Orn
Copy link
Collaborator

We can now run unit tests locally on branch #45 and have added 3 very simple unit tests for the metrics file.

Having some getting the tests to run with GHA, some import issues keep occuring

@Eysteinn-Orn
Copy link
Collaborator

actually rather, this might be a missing CUDA library files problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eysteinn-Orn Eysteinn-Orn

@lsig lsig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njallskarp @Eysteinn-Orn @lsig