none-ls: updating + refactoring

[MattSturgeon]

Overview issue to track specific issues, PRs, and ideas related to updating and refactoring none-ls.

• Switch to mkNeovimPlugin (move options to settings)
  • plugins/none-ls: switch to mkNeovimPlugin #1727
• Move sources.*.withArgs to sources.*.settings
  • plugins/none-ls: use rfc42 style #1724
  • Use either strLua submodule to allow a rename-alias
  • Include "filetypes" from builtins.json in option types/defaults/descriptions?
• Consider how enableLspFormat should work with rfc42 settings?
  • When enabled, it sets on_attach default to require('lsp-format').on_attach.
  • Maybe we should just suggest users include this in their on_attach manually?
  • Current description is misleading: [BUG] lsp-format should get enabled if enabling enableLspFormat #1690
• Deprecate auto-enabling gitsigns?
  • Show a warning if there are not multiple definitions of plugins.gitsigns.enable.
  • Eventually, show a warning instead of auto-enabling.
• Chore: attempt re-enabling disabled sources tests
• Support "custom" sources submodules
  • Custom sources need to be registered first
  • Submodule shape: { method, generator, filetypes[], name?, condition? }.
• General refactoring
  • Use a mkModule-style helper: plugins/none-ls: refactor using mkSourcePlugin #1853
  • Move "builtin sources packages" list into a dedicated file
  • Simplify pkg states: can be derivation or bool, don't need null.
  • Move builtinPackages out of sync with builtins.json errors out of module and into a CI check
• Replace IFD with update script plugin/none-ls: Use a generated file #1814

General notes and discussion can be had on this issue, but I'd encourage opening discussions or issues for specific issues. These can be linked in the relevant checklist above.

Tagging @traxys because he's done most of the work on the none-ls module so far.

[traxys]

Consider how enableLspFormat should work with rfc42 settings?

I'd say we leave it as a top level option, top level options are options that are defined by nixvim, not the wrapped plugin

[MattSturgeon]

Consider how enableLspFormat should work with rfc42 settings?

I'd say we leave it as a top level option, top level options are options that are defined by nixvim, not the wrapped plugin

Are we still happy for it to default to true (when lsp-format is enabled)? I think that's a sane default, but it is configuring things for the user without them explicitly enabling anything...

[traxys]

I have mostly taken the approach of avoiding to introduce new magic in nixvim in the last year, so if it were a new plugin i'd suggest not defaulting to false.
For this specific case I don't know

[niksingh710]

If I enable the lsp-format plugin and set enableLspFormat to true in none-LS, the files are automatically formatted on save. Is there a way to disable this behavior?