Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Swipe left"/"Swipe right" does not work correctly #7

Closed
programmerr47 opened this issue Jun 23, 2016 · 4 comments
Closed

"Swipe left"/"Swipe right" does not work correctly #7

programmerr47 opened this issue Jun 23, 2016 · 4 comments

Comments

@programmerr47
Copy link
Contributor

Tested sample app on Nexus 5, Android 6.0. Try to swipe to right, it shows "Swipe left" label. Moreover when try to swipe to top or bottom, it shows "swipe left".
@nisrulz
Copy link
Owner

nisrulz commented Jun 23, 2016

The code is in develop branch, not fully functional. The final release will have it working.

@programmerr47
Copy link
Contributor Author

Hi. Thank you for your reply. I've already have, as I think, fix for that. And also I wrote tests for all classes. If you don't mind, I would like to make pull request.

@nisrulz
Copy link
Owner

nisrulz commented Jun 24, 2016

All pull request/contribution are welcome. Go ahead and send it.

@nisrulz
Copy link
Owner

nisrulz commented Jun 24, 2016

Code merged from pull request #8 , some fixes added and code cleanup done and new version is released at commit 32edad6

Closing this issue as the latest version 1.3.0 includes all fixes and solves this issue

@nisrulz nisrulz closed this as completed Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@programmerr47 @nisrulz