Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New permission added: RECORD_AUDIO. Is it possible to remove it? #32

Closed
amanzan opened this issue Oct 3, 2017 · 9 comments
Closed

New permission added: RECORD_AUDIO. Is it possible to remove it? #32

amanzan opened this issue Oct 3, 2017 · 9 comments

Comments

@amanzan
Copy link

amanzan commented Oct 3, 2017

I added this library to my project, and when trying to upload the apk to Google Play, I get the following warning:
WARNING
Users that have the APK with version code 10 may need to accept the android.permission.RECORD_AUDIO permission, which may result in them not upgrading to this version of the app.

I assume this is for the "Sound Level Detection" and I see this permission is added to the library's AndroidManifest. Would it be possible to remove it? I think it's a better option that whoever needs this feature, adds this permission by himself/herself to avoid warnings even when not needed

@nisrulz
Copy link
Owner

nisrulz commented Oct 3, 2017

Its actually been removed in the develop branch (which I am yet to push to github). I just haven't released it in the master branch as a release.

@amanzan
Copy link
Author

amanzan commented Oct 4, 2017

Ah ok, thanks! When are you planning on releasing the new version?

@nisrulz
Copy link
Owner

nisrulz commented Oct 4, 2017

I think I can release it by this weekend.

@martinflorek
Copy link

@nisrulz anything new about this issue? and thanks for this great library!

@nisrulz
Copy link
Owner

nisrulz commented Nov 27, 2017

@martinflorek I had been traveling. I have been working on one version of this library which is a major update, but I see the permission problem. I will release a version without the permission asap and then move to the next major release.

Please give me sometime, possibly a day or two and I will surely push out a version so that the permission issue is solved.

Thank you for your patience and using this library.

@martinflorek
Copy link

@nisrulz thanks for the quick reply and for the hard work.

I needed to release a beta version of my app asap, so I have just removed the permission from my app via Gradle. Hope it will not cause issues in release build (I am using just the shake detector) and I will wait for your stable release for my stable release. Thank you again.

@nisrulz
Copy link
Owner

nisrulz commented Dec 5, 2017

@martinflorek I have just released a new version of Sensey (v.1.8.0), which addresses this issue. Please checkout the changelog for breaking changes in this release here

Apologies for the delayed update for this bug.
Thank you for your patience and using this library.

Please close this issue if your issue is resolved.

@martinflorek
Copy link

@nisrulz Thank you! I will test it tonight. My app is targeting API 19 and up so there should not be a problem.

@martinflorek
Copy link

@nisrulz Works good, issue can be closed. Thank you.

@nisrulz nisrulz closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants