From c801c33d9987d638620ef6d9e16d37e273e13413 Mon Sep 17 00:00:00 2001 From: Nirvana Tikku Date: Fri, 2 Dec 2016 20:30:21 -0500 Subject: [PATCH 1/5] Expose the default settings publicly --- src/tubeplayer.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tubeplayer.js b/src/tubeplayer.js index 1fe60eb..731a44e 100644 --- a/src/tubeplayer.js +++ b/src/tubeplayer.js @@ -135,7 +135,7 @@ * plugin to work without providing any parameters. They * are merged with the users options. */ - var defaults = { + $.tubeplayer.defaults.settings = { // public facing width: 480, @@ -222,7 +222,7 @@ 'id' : ids ? ids : '' }); $this.replaceWith(newDiv); - var new_input = $.extend({}, defaults, settings, input); + var new_input = $.extend({}, $.tubeplayer.defaults.settings, settings, input); TP.init(newDiv, new_input); } } else { @@ -277,7 +277,7 @@ if ($player.hasClass(TUBEPLAYER_CLASS)) { return $player; } - var o = $.extend({}, defaults, opts); + var o = $.extend({}, $.tubeplayer.defaults.settings, opts); o.playerID += "-" + guid(); $player.addClass(TUBEPLAYER_CLASS).data(OPTS, o); for (var event in PlayerEvents){ From 39a6d2351edabe17b225ca18639af5416b60b62c Mon Sep 17 00:00:00 2001 From: Nirvana Tikku Date: Fri, 2 Dec 2016 20:56:03 -0500 Subject: [PATCH 2/5] New player event: "onPlayerLoaded". Complements $.tubeplayer.defaults.afterReady. --- src/tubeplayer.js | 8 ++++++-- test_console/index.html | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/tubeplayer.js b/src/tubeplayer.js index 731a44e..3bae754 100644 --- a/src/tubeplayer.js +++ b/src/tubeplayer.js @@ -120,7 +120,8 @@ playing: {}, paused: {}, buffering: {}, - cued: {} + cued: {}, + loaded: {} }, onErr: { defaultError: {}, @@ -166,6 +167,7 @@ onUnMute: function() {}, // functions called when events are triggered from the youtube player itself + onPlayerLoaded: function(){}, onPlayerUnstarted: function() {}, onPlayerEnded: function() {}, onPlayerPlaying: function() {}, @@ -339,6 +341,7 @@ 'onReady': function(evt) { TP.ytplayers[o.playerID] = evt.target; var $player = $(evt.target.getIframe()).parents("." + TUBEPLAYER_CLASS); + $player.tubeplayer('opts').onPlayerLoaded.call($player); $.tubeplayer.defaults.afterReady($player); }, 'onPlaybackQualityChange': $.tubeplayer.defaults.qualityChange(o.playerID), @@ -382,6 +385,7 @@ dp.paused[ID] = o.onPlayerPaused; dp.buffering[ID] = o.onPlayerBuffering; dp.cued[ID] = o.onPlayerCued; + dp.loaded[ID] = o.onPlayerLoaded; // default onQualityChange d.onQualityChange[ID] = o.onQualityChange; @@ -589,7 +593,7 @@ delete TP.ytplayers[p.opts.playerID]; // cleanup callback handler references.. var d = $.tubeplayer.defaults; - var events = ['unstarted', 'ended', 'playing', 'paused', 'buffering', 'cued']; + var events = ['unstarted', 'ended', 'playing', 'paused', 'buffering', 'cued', 'loaded']; $.each(events, function(i, event) { delete d.onPlayer[event][p.opts.playerID]; }); diff --git a/test_console/index.html b/test_console/index.html index 22adb2b..9447c89 100644 --- a/test_console/index.html +++ b/test_console/index.html @@ -483,6 +483,9 @@

Player Activity Callbacks

onPlayerCued: function(){ printPlayerUpdate("CUED (onPlayerCued)"); }, + onPlayerLoaded: function(){ + printPlayerUpdate("LOADED (onPlayerLoaded)"); + }, onQualityChange: function(qual){ printPlayerUpdate("QUALITY CHANGED: " + qual +" (onQualityChange)"); }, From 8219ff1d7cc1e69f873cde8803f891ac09081c80 Mon Sep 17 00:00:00 2001 From: Nirvana Tikku Date: Fri, 2 Dec 2016 21:06:25 -0500 Subject: [PATCH 3/5] Fix test console URL --- test_console/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_console/index.html b/test_console/index.html index 9447c89..afa49c8 100644 --- a/test_console/index.html +++ b/test_console/index.html @@ -48,7 +48,7 @@