Skip to content

Commit fbe6aae

Browse files
authored
Merge pull request #197 from nirtal85/docker
docker
2 parents 92dac1f + f4521fe commit fbe6aae

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

.github/workflows/devRun.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ jobs:
88
merge_test:
99
timeout-minutes: 15
1010
runs-on: ubuntu-latest
11+
container:
12+
image: mcr.microsoft.com/playwright:v1.51.0-jammy
1113
steps:
1214
- uses: actions/checkout@v4
1315
- name: Set up Python
@@ -22,10 +24,6 @@ jobs:
2224
run: |
2325
uv venv
2426
uv sync --all-extras --dev
25-
- name: Install Playwright Browsers
26-
run: |
27-
PLAYWRIGHT_VERSION=$(grep -E '^playwright = "[^"]*"' pyproject.toml | sed -E 's/playwright = "([^"]*)".*$/\1/')
28-
npx playwright@$PLAYWRIGHT_VERSION install --with-deps
2927
- name: Test with pytest
3028
run: xvfb-run .venv/bin/python -m pytest -m devRun --base-url ${{ vars.BASE_URL }}
3129
- name: Auto-assign reviewers

.github/workflows/nightly.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ jobs:
3131
nightly-test:
3232
needs: setup-matrix
3333
runs-on: ubuntu-latest
34+
container:
35+
image: mcr.microsoft.com/playwright:v1.51.0-jammy
3436
strategy:
3537
fail-fast: false
3638
matrix: ${{ fromJson(needs.setup-matrix.outputs.matrix) }}
@@ -48,10 +50,6 @@ jobs:
4850
run: |
4951
uv venv
5052
uv sync --all-extras --dev
51-
- name: Install Playwright Browsers
52-
run: |
53-
PLAYWRIGHT_VERSION=$(grep -E '^playwright = "[^"]*"' pyproject.toml | sed -E 's/playwright = "([^"]*)".*$/\1/')
54-
npx playwright@$PLAYWRIGHT_VERSION install --with-deps
5553
- name: Run Tests
5654
run: |
5755
xvfb-run .venv/bin/python -m pytest ${{ github.event.inputs.pytest_command || '-m "not devRun"' }} \

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ addopts = [
5454
"tms:https://{}",
5555
"-ra",
5656
"--color=yes",
57-
"--browser-channel=chrome",
57+
"--browser=chromium",
5858
"--headed",
5959
"--video=retain-on-failure",
6060
"--tracing=retain-on-failure"

0 commit comments

Comments
 (0)