feat: add test id

Author: Nir.Tal

pages/login_page.py

@@ -13,10 +13,10 @@
 class LoginPage:
     def __init__(self, page: Page):
         self.page = page
-        self.user_name_field = page.locator("[data-test='username']")
-        self.password_field = page.locator("[data-test='password']")
-        self.login_button = page.locator("[data-test='login-button']")
-        self.error_message = page.locator("[data-test='error']")
+        self.user_name_field = page.get_by_test_id("username")
+        self.password_field = page.get_by_test_id("password")
+        self.login_button = page.get_by_test_id("login-button")
+        self.error_message = page.get_by_test_id("error")
 
     @allure.step("Login with username {username} and password {password}")
     def login(self, username: Union[User, str], password: str):

tests/conftest.py

@@ -6,7 +6,7 @@
 from _pytest.fixtures import FixtureRequest, SubRequest
 from _pytest.nodes import Item
 from axe_playwright_python.sync_playwright import Axe
-from playwright.sync_api import Page
+from playwright.sync_api import Page, Playwright
 
 from utilities.axe_helper import AxeHelper
 from utilities.constants import Constants
@@ -85,17 +85,26 @@ def browser_context_args(
 
 
 @pytest.fixture(scope="session")
-def browser_type_launch_args(browser_type_launch_args: Dict):
+def browser_type_launch_args(browser_type_launch_args: Dict, playwright: Playwright):
     """Fixture to set browser launch arguments.
 
+    This fixture updates the browser launch arguments to start the browser maximized
+    and sets the test ID attribute for selectors.
+
     Args:
-        browser_type_launch_args (dict): Browser type launch arguments.
+        browser_type_launch_args (Dict): Original browser type launch arguments.
+        playwright (Playwright): The Playwright instance.
 
     Returns:
-        dict: Updated browser type launch arguments.
+        Dict: Updated browser type launch arguments with maximized window setting.
+
+    Note:
+        This fixture has a session scope, meaning it will be executed once per test session.
+
     See Also:
         https://playwright.dev/python/docs/api/class-browsertype#browser-type-launch
     """
+    playwright.selectors.set_test_id_attribute("data-test")
     return {**browser_type_launch_args, "args": ["--start-maximized"]}
 
 

tests/inventory_test.py

@@ -10,4 +10,4 @@ class TestInventory:
         "browser_context_args", [User.STANDARD_USER], indirect=True
     )
     def test_inventory_page(self, browser_context_args, page: Page):
-        expect(page.locator("//span[@class='title']")).to_have_text("Products")
+        expect(page.get_by_test_id("title")).to_have_text("Products")