From 213f488314bb4289c125f104ca03d2ceec0595a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= Date: Tue, 17 May 2022 15:18:00 +0200 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20use=20inline=20keyword.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Again, I am a Pythonista, just recording exisitng SUSE patches, so I miss a lot of intricacies of GCC keywords, but it seems from many sources (https://bugs.launchpad.net/flashlight-firmware/+bug/1703250, https://www.kernel.org/doc/local/inline.html) that `inline` keyword is frowned upon. --- src/dmixml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dmixml.c b/src/dmixml.c index 682acc7..4c1cdfd 100644 --- a/src/dmixml.c +++ b/src/dmixml.c @@ -362,7 +362,7 @@ xmlNode *dmixml_FindNode(xmlNode *node, const char *key) { * @return char* Pointer to the tag contents if found, otherwise NULL. This value * must NOT be freed, as it points directly into the value in the XML document. */ -inline char *dmixml_GetContent(xmlNode *node) { +char *dmixml_GetContent(xmlNode *node) { // FIXME: Should find better way how to return UTF-8 data return (((node != NULL) && (node->children != NULL)) ? (char *) node->children->content : NULL); } @@ -377,7 +377,7 @@ inline char *dmixml_GetContent(xmlNode *node) { * @return char* Pointer to the tag contents if found, otherwise NULL. This value * must NOT be freed, as it points directly into the value in the XML document. */ -inline char *dmixml_GetNodeContent(xmlNode *node, const char *key) { +char *dmixml_GetNodeContent(xmlNode *node, const char *key) { return dmixml_GetContent(dmixml_FindNode(node, key)); }