add TODOs

Author: miguelmartin75

compiler/commands.nim

@@ -1154,11 +1154,17 @@ proc processSwitch*(switch, arg: string, pass: TCmdLinePass, info: TLineInfo;
     handleStdinInput(conf)
   of "nilseqs", "nilchecks", "symbol", "taintmode", "cs", "deadcodeelim": warningOptionNoop(switch)
   of "nimmainprefix": conf.nimMainPrefix = arg
-  of "compilecmdjson":
+  of "compilecmdsjson":
+    # TODO
+    # processOnOffSwitch(conf, {optCursorInference}, arg, pass, info)
     conf.compileCommandsJson = true
   of "projectcompilecmdjson":
+    # TODO
+    # processOnOffSwitch(conf, {optCursorInference}, arg, pass, info)
     conf.projectCompileCommandJsons = true
-  of "copycommandjson":
+  of "rootcompilecmdsjson":
+    # TODO
+    # processOnOffSwitch(conf, {optCursorInference}, arg, pass, info)
     conf.copyCompileCommandsJsonToCurDir = true
   else:
     if strutils.find(switch, '.') >= 0: options.setConfigVar(conf, switch, arg)

compiler/extccomp.nim

@@ -1004,9 +1004,6 @@ proc callCCompiler*(conf: ConfigRef) =
 template hashNimExe(): string = $secureHashFile(os.getAppFilename())
 
 iterator compileCommandsJsonFiles*(conf: ConfigRef): AbsoluteFile =
-  # `outFile` is better than `projectName`, as it allows having different json
-  # files for a given source file compiled with different options; it also
-  # works out of the box with `hashMainCompilationParams`.
   var rf = if conf.projectCompileCommandJsons:
     ("compile_commands_" & conf.outFile.changeFileExt("json").string).RelativeFile
   else:
@@ -1015,8 +1012,8 @@ iterator compileCommandsJsonFiles*(conf: ConfigRef): AbsoluteFile =
   yield getNimcacheDir(conf) / rf
 
   if conf.copyCompileCommandsJsonToCurDir:
-    # TODO
-    yield getNimcacheDir(conf) / rf
+    # TODO: current dir
+    yield conf.projectPath / rf
 
 
 proc jsonBuildInstructionsFile*(conf: ConfigRef): AbsoluteFile =
@@ -1089,8 +1086,8 @@ proc writeJsonBuildInstructions*(conf: ConfigRef; deps: StringTableRef) =
 
   conf.jsonBuildFile.string.writeFile(bcache.toJson.pretty)
 
-  # NOTE: compile_commands.json uses indent of 2 by convention
   if conf.compileCommandsJson:
+    # NOTE: compile_commands.json uses indent of 2 by convention
     let compileCmds = conf.jsonCompileCommands.pretty(2)
     for p in conf.compileCommandsJsonFiles:
       p.writeFile(compileCmds)

tests/compile_commands_json/foo.nims

@@ -1 +1,2 @@
 --nimcache:"./nimcache"
+--compileCmdsJson:on