Drop Sonnet 4.6, add Sonnet 5#178
Conversation
Replace the Claude-provider Sonnet 4.6 model with Sonnet 5 (claude-sonnet-5), exposing the full reasoning level set (low/medium/high/xhigh/max, default xhigh) and a 128000 output ceiling. Sonnet 5 supports output_config.effort:max natively, so remove the Sonnet 4.6-only max-thinking workaround in ThinkingProxy.
There was a problem hiding this comment.
Code Review
This pull request upgrades the supported Claude Sonnet model from version 4.6 to version 5. Key changes include updating the model identifier to claude-sonnet-5, doubling the maximum output tokens to 128,000, and setting the default reasoning effort to xhigh. It also removes the legacy workaround logic and associated tests for Sonnet 4.6's max-thinking effort level, as Sonnet 5 natively supports the full range of advanced thinking levels. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoves Sonnet 4.6-specific max-thinking JSON transform logic from ChangesSonnet 5 migration and Sonnet 4.6 max-thinking removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Replaces the Claude-provider Sonnet 4.6 model with Sonnet 5 (
claude-sonnet-5).low/medium/high/xhigh/max, defaultxhigh) with a128000output ceiling, matching Opus 4.8.output_config.effort: maxnatively, so the Sonnet 4.6-only max-thinking workaround inThinkingProxy(which rewrotemaxrequests into classicthinking:{type:enabled,budget_tokens}and pinnedmax_tokens) is removed.Changes
DroidProxyModelCatalog.swift—claude-sonnet-4-6→claude-sonnet-5(slugsonnet-5, "Sonnet 5"),maxOutputTokens: 128000,claudeAdvancedLevels, defaultxhigh. Removed the unusedclaudeSonnetLevelsstatic.ThinkingProxy.swift— deleted the max-thinking call site, constants, and theapplySonnetMaxThinking/sonnetRequestsMaxEffort/pinSonnetMaxThinkingMaxTokenshelpers; updated the class doc comment.ThinkingProxySonnetMaxThinkingTests.swift; updated the catalog test for Sonnet 5.AGENTS.md— updated the Claude thinking reference to Sonnet 5.The separate Antigravity
ag-c46s-thinking("Claude Sonnet 4.6 (Thinking)") entry is unchanged.Verification
swift buildandswift testboth pass (17 tests, 0 failures).