Skip to content

Drop Sonnet 4.6, add Sonnet 5#178

Merged
nikships merged 1 commit into
mainfrom
drop-sonnet-46-add-sonnet-5
Jun 30, 2026
Merged

Drop Sonnet 4.6, add Sonnet 5#178
nikships merged 1 commit into
mainfrom
drop-sonnet-46-add-sonnet-5

Conversation

@nikships

Copy link
Copy Markdown
Owner

Summary

Replaces the Claude-provider Sonnet 4.6 model with Sonnet 5 (claude-sonnet-5).

  • Catalog entry now exposes the full reasoning level set (low/medium/high/xhigh/max, default xhigh) with a 128000 output ceiling, matching Opus 4.8.
  • Sonnet 5 supports output_config.effort: max natively, so the Sonnet 4.6-only max-thinking workaround in ThinkingProxy (which rewrote max requests into classic thinking:{type:enabled,budget_tokens} and pinned max_tokens) is removed.

Changes

  • DroidProxyModelCatalog.swiftclaude-sonnet-4-6claude-sonnet-5 (slug sonnet-5, "Sonnet 5"), maxOutputTokens: 128000, claudeAdvancedLevels, default xhigh. Removed the unused claudeSonnetLevels static.
  • ThinkingProxy.swift — deleted the max-thinking call site, constants, and the applySonnetMaxThinking / sonnetRequestsMaxEffort / pinSonnetMaxThinkingMaxTokens helpers; updated the class doc comment.
  • Tests — removed ThinkingProxySonnetMaxThinkingTests.swift; updated the catalog test for Sonnet 5.
  • AGENTS.md — updated the Claude thinking reference to Sonnet 5.

The separate Antigravity ag-c46s-thinking ("Claude Sonnet 4.6 (Thinking)") entry is unchanged.

Verification

swift build and swift test both pass (17 tests, 0 failures).

Replace the Claude-provider Sonnet 4.6 model with Sonnet 5 (claude-sonnet-5),
exposing the full reasoning level set (low/medium/high/xhigh/max, default xhigh)
and a 128000 output ceiling. Sonnet 5 supports output_config.effort:max natively,
so remove the Sonnet 4.6-only max-thinking workaround in ThinkingProxy.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the supported Claude Sonnet model from version 4.6 to version 5. Key changes include updating the model identifier to claude-sonnet-5, doubling the maximum output tokens to 128,000, and setting the default reasoning effort to xhigh. It also removes the legacy workaround logic and associated tests for Sonnet 4.6's max-thinking effort level, as Sonnet 5 natively supports the full range of advanced thinking levels. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2785dce4-c8b8-4100-af47-7e44778698e7

📥 Commits

Reviewing files that changed from the base of the PR and between 2756209 and 4256c60.

📒 Files selected for processing (5)
  • AGENTS.md
  • src/Sources/DroidProxyModelCatalog.swift
  • src/Sources/ThinkingProxy.swift
  • src/Tests/CLIProxyMenuBarTests/DroidProxyModelCatalogTests.swift
  • src/Tests/CLIProxyMenuBarTests/ThinkingProxySonnetMaxThinkingTests.swift

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Updated the supported Claude adaptive model to a newer Sonnet release with higher output limits and a higher default reasoning level.
  • Bug Fixes

    • Simplified request handling so reasoning requests are forwarded without the previous Sonnet-specific conversion step.
    • Refreshed the supported reasoning options to include the newest higher-effort settings.
  • Documentation

    • Updated the model/behavior notes to match the latest supported Claude versions.

Walkthrough

Removes Sonnet 4.6-specific max-thinking JSON transform logic from ThinkingProxy.swift (call site, helpers, constants), replaces the Sonnet 4.6 model catalog entry with a Sonnet 5 entry using updated tokens and reasoning levels, and updates tests and docs to match.

Changes

Sonnet 5 migration and Sonnet 4.6 max-thinking removal

Layer / File(s) Summary
Remove Sonnet 4.6 max-thinking transform
src/Sources/ThinkingProxy.swift, src/Tests/CLIProxyMenuBarTests/ThinkingProxySonnetMaxThinkingTests.swift
Removes the call to the Sonnet 4.6 max-thinking transformer in POST request handling, deletes all associated helper constants and methods (~85 lines), removes the class doc bullet, and deletes the entire ThinkingProxySonnetMaxThinkingTests test file.
Replace Sonnet 4.6 catalog entry with Sonnet 5
src/Sources/DroidProxyModelCatalog.swift, src/Tests/CLIProxyMenuBarTests/DroidProxyModelCatalogTests.swift, AGENTS.md
Removes claudeSonnetLevels constant, replaces the Sonnet 4.6 DroidProxyModelDefinition with a Sonnet 5 entry (maxOutputTokens: 128000, defaultLevelValue: "xhigh", levels: claudeAdvancedLevels), updates catalog tests to assert Sonnet 5 fields, and updates the AGENTS.md model reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • nikships/droidproxy#28: Added the Sonnet max-budget thinking injection in ThinkingProxy.swift that this PR removes.
  • nikships/droidproxy#32: Modified ThinkingProxy.swift branching on sonnet-4-6 max-budget behavior, directly overlapping with the transform deleted here.
  • nikships/droidproxy#44: Reworked max-budget classic thinking override logic for Sonnet 4.6 that this PR's deletions supersede.

Poem

🐇 Sonnet four-point-six, farewell, goodbye,
No more max-thinking transforms on the fly.
Sonnet Five hops in with xhigh in its name,
128k tokens — a much bigger game!
The rabbit clips the old wires, clean and neat. ✂️

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-sonnet-46-add-sonnet-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nikships nikships merged commit 845e344 into main Jun 30, 2026
7 of 8 checks passed
@nikships nikships deleted the drop-sonnet-46-add-sonnet-5 branch June 30, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant