Fixed socket deletion error (#59)

Skycoder42 · web-flow · commit 30ac5715d123 · 2020-12-28T22:05:32.000-08:00
* Fixed socket deletion error

deleting the socket in the destructor can cause a crash when shutting down the app. By moving it to the socketDisconnected and deleting it with "deleteLater" fixed the issue

* fixed intendation
diff --git a/src/qhttpconnection.cpp b/src/qhttpconnection.cpp
@@ -61,7 +61,6 @@ QHttpConnection::QHttpConnection(QTcpSocket *socket, QObject *parent)
 
 QHttpConnection::~QHttpConnection()
 {
-    delete m_socket;
     m_socket = 0;
 
     free(m_parser);
@@ -73,8 +72,9 @@ QHttpConnection::~QHttpConnection()
 
 void QHttpConnection::socketDisconnected()
 {
-    deleteLater();
     invalidateRequest();
+    m_socket->deleteLater();
+    deleteLater();
 }
 
 void QHttpConnection::invalidateRequest()

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ QHttpConnection::QHttpConnection(QTcpSocket socket, QObject parent)`
`61`	`61`
`62`	`62`	`QHttpConnection::~QHttpConnection()`
`63`	`63`	`{`
`64`		`- delete m_socket;`
`65`	`64`	`m_socket = 0;`
`66`	`65`
`67`	`66`	`free(m_parser);`
`@@ -73,8 +72,9 @@ QHttpConnection::~QHttpConnection()`
`73`	`72`
`74`	`73`	`void QHttpConnection::socketDisconnected()`
`75`	`74`	`{`
`76`		`- deleteLater();`
`77`	`75`	`invalidateRequest();`
	`76`	`+ m_socket->deleteLater();`
	`77`	`+ deleteLater();`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`void QHttpConnection::invalidateRequest()`