Skip to content

Commit 2d40cdf

Browse files
committed
Fix fixdats with complete-games-only.
1 parent a6de6ef commit 2d40cdf

3 files changed

Lines changed: 26 additions & 1 deletion

File tree

regress/fixdat-missing-both.fixdat

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
3+
<datafile>
4+
<header>
5+
<name>Fixdat for ckmame test db (1)</name>
6+
<description>Fixdat by ckmame</description>
7+
<version>0000-00-00 00:00:00</version>
8+
<author>automatically generated</author>
9+
</header>
10+
<game name="clone-8">
11+
<description>clone-8</description>
12+
<rom name="04.rom" size="4" crc="d87f7e0c"/>
13+
<rom name="08.rom" size="8" crc="3656897d"/>
14+
</game>
15+
</datafile>
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
description test all games, one rom missing, create fixdat
2+
features HAVE_LIBXML2
3+
return 0
4+
arguments --no-status-db --complete-games-only -Fvc -D ../mamedb-lost-parent-ok.db --create-fixdat
5+
file "fixdat_ckmame test db (1).dat" {} fixdat-missing-both.fixdat
6+
directory roms <>
7+
stdout
8+
In game clone-8:
9+
game clone-8 : not a single file found
10+
end-of-inline-data

src/check_game_files.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ void check_game_files(Game* game, filetype_t filetype, GameArchives* archives, R
107107

108108
if (rom.where == FILE_INGAME && match->quality == Match::MISSING && rom.hashes.size > 0 &&
109109
!rom.hashes.empty() && rom.status != Rom::NO_DUMP) {
110-
if (configuration.complete_games_only) {
110+
if (configuration.complete_games_only && !configuration.create_fixdat) {
111111
match->quality = Match::UNCHECKED;
112112
if (missing_roms) {
113113
continue;

0 commit comments

Comments
 (0)