fix: leastconn skips first backend

karlvr · karlvr · commit 52a9196f8a61 · 2024-11-15T09:26:34.000+13:00
diff --git a/src/vmod_dynamic.c b/src/vmod_dynamic.c
@@ -272,8 +272,6 @@ dom_find_leastconn(VRT_CTX, struct dynamic_domain *dom)
 
 	do {
 		CHECK_OBJ_ORNULL(next, DYNAMIC_REF_MAGIC);
-		if (next != NULL)
-			next = VTAILQ_NEXT(next, list);
 		if (next == NULL)
 			break;
 
@@ -290,6 +288,8 @@ dom_find_leastconn(VRT_CTX, struct dynamic_domain *dom)
 				}
 			}
 		}
+
+		next = VTAILQ_NEXT(next, list);
 	} while (1);
 
 	if (best_next != NULL) {

Original file line number	Diff line number	Diff line change
`@@ -272,8 +272,6 @@ dom_find_leastconn(VRT_CTX, struct dynamic_domain *dom)`
`272`	`272`
`273`	`273`	`do {`
`274`	`274`	`CHECK_OBJ_ORNULL(next, DYNAMIC_REF_MAGIC);`
`275`		`- if (next != NULL)`
`276`		`- next = VTAILQ_NEXT(next, list);`
`277`	`275`	`if (next == NULL)`
`278`	`276`	`break;`
`279`	`277`
`@@ -290,6 +288,8 @@ dom_find_leastconn(VRT_CTX, struct dynamic_domain *dom)`
`290`	`288`	`}`
`291`	`289`	`}`
`292`	`290`	`}`
	`291`	`+`
	`292`	`+ next = VTAILQ_NEXT(next, list);`
`293`	`293`	`} while (1);`
`294`	`294`
`295`	`295`	`if (best_next != NULL) {`