update function now respects dropped observaiton intercepts

Nicholas Clark · Nicholas Clark · commit d422646b3903 · 2024-02-06T14:10:14.000+10:00
diff --git a/R/mvgam.R b/R/mvgam.R
@@ -1630,6 +1630,9 @@ mvgam = function(formula,
       }
 
       vectorised$model_file <- readLines(textConnection(vectorised$model_file), n = -1)
+      attr(ss_gam, 'drop_obs_intercept') <- TRUE
+    } else {
+      attr(ss_gam, 'drop_obs_intercept') <- FALSE
     }
 
     # Remaining model file updates for any GP terms
diff --git a/R/update.mvgam.R b/R/update.mvgam.R
@@ -40,6 +40,10 @@ update.mvgam = function(object, formula,
 
   if(missing(formula)){
     formula <- object$call
+
+    if(attr(object$mgcv_model, 'drop_obs_intercept')){
+      formula <- update(formula, ~ . -1)
+    }
   }
 
   if(missing(trend_formula)){
diff --git a/src/mvgam.dll b/src/mvgam.dll

Original file line number	Diff line number	Diff line change
`@@ -1630,6 +1630,9 @@ mvgam = function(formula,`
`1630`	`1630`	`}`
`1631`	`1631`
`1632`	`1632`	`vectorised$model_file <- readLines(textConnection(vectorised$model_file), n = -1)`
	`1633`	`+ attr(ss_gam, 'drop_obs_intercept') <- TRUE`
	`1634`	`+ } else {`
	`1635`	`+ attr(ss_gam, 'drop_obs_intercept') <- FALSE`
`1633`	`1636`	`}`
`1634`	`1637`
`1635`	`1638`	`# Remaining model file updates for any GP terms`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@ update.mvgam = function(object, formula,`
`40`	`40`
`41`	`41`	`if(missing(formula)){`
`42`	`42`	`formula <- object$call`
	`43`	`+`
	`44`	`+ if(attr(object$mgcv_model, 'drop_obs_intercept')){`
	`45`	`+ formula <- update(formula, ~ . -1)`
	`46`	`+ }`
`43`	`47`	`}`
`44`	`48`
`45`	`49`	`if(missing(trend_formula)){`