From ac39524b6d8c9fb50089d5fb540ce7475572a024 Mon Sep 17 00:00:00 2001
From: Nicholas Clark <uqnclar2@uq.edu.au>
Date: Fri, 4 Oct 2024 08:29:21 +1000
Subject: [PATCH] fix drawing of Hilbert GP smooths using gratia

---
 R/gratia_methods.R |  12 ++++++------
 src/mvgam.dll      | Bin 1091584 -> 1091584 bytes
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/R/gratia_methods.R b/R/gratia_methods.R
index b96289ec..19973cc7 100644
--- a/R/gratia_methods.R
+++ b/R/gratia_methods.R
@@ -338,12 +338,12 @@ eval_smoothDothilbertDotsmooth = function(smooth,
     n = n, n_3d = n_3d, n_4d = n_4d,
     id = which_smooth(
       model,
-      gratia::smooth_label(smooth)
+      smooth_label(smooth)
     )
   )
 
   # by variables
-  by_var <- gratia::by_variable(smooth)
+  by_var <- by_variable(smooth)
   if (by_var == "NA") {
     by_var <- NA_character_
   }
@@ -353,7 +353,6 @@ eval_smoothDothilbertDotsmooth = function(smooth,
   by <- unlist(purrr::map(gp_att_table, 'by'))
   level <- unlist(purrr::map(gp_att_table, 'level'))
   gp_covariate <- smooth$term
-  by <- smooth$by
   level <- ifelse(is.null(smooth$by.level), NA, smooth$by.level)
   k <- unlist(purrr::map(gp_att_table, 'k'))
   scale <- unlist(purrr::map(gp_att_table, 'scale'))
@@ -365,17 +364,17 @@ eval_smoothDothilbertDotsmooth = function(smooth,
   # Which GP term are we plotting?
   if(!is.na(level)){
     gp_select <- which(unlist(purrr::map(gp_att_table, 'covariate')) == gp_covariate &
-                         unlist(purrr::map(gp_att_table, 'by')) == by &
+                         which(by %in% by_var) &
                          unlist(purrr::map(gp_att_table, 'level')) == level)
   } else {
     gp_select <- which(unlist(purrr::map(gp_att_table, 'covariate')) == gp_covariate &
-                         unlist(purrr::map(gp_att_table, 'by')) == by)
+                         which(by %in% by_var))
   }
 
   # Compute eigenfunctions for this GP term
   X <- prep_eigenfunctions(data = data,
                            covariate = gp_covariate,
-                           by = by,
+                           by = by_var,
                            level = level,
                            k = k[gp_select],
                            boundary = boundary[gp_select],
@@ -430,6 +429,7 @@ eval_smoothDothilbertDotsmooth = function(smooth,
 
   ## identify which vars are needed for this smooth...
   keep_vars <- c(smooth$term, smooth$by)
+  keep_vars <- keep_vars[!keep_vars %in% 'NA']
 
   ## ... then keep only those vars
   data <- dplyr::select(data, dplyr::all_of(keep_vars))
diff --git a/src/mvgam.dll b/src/mvgam.dll
index b085540d915bfca537b6dd5964ebf8cd2bcd7306..b6dd2522e571de3995eceea0830dcaa5cb3ddccb 100644
GIT binary patch
delta 81
zcmZp;;M8!zX+j6{CCUF2yM3AGJQrxZ-Flm`^)^%MZRXb7EUmX$TW_<q-ezyT&Cz<B
lv-LJt>uv7V+dQqed0TJuwch66dRsu#8>D?ZyN|%nXaGd)CJX=o

delta 81
zcmV-X0IvUl&_aOFLXe09lXd)&i%kO;pAmuEh1&sz+X98#1BKfJh1&&%+XjW(2Zh@R
nh1&^*+X{u-3x(SZh1(5<+YW`>54GD6DN6&Ab^NynOc42780#f-