Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string as input of of() #194

Open
5 tasks
niccokunzmann opened this issue Oct 21, 2024 · 0 comments
Open
5 tasks

Add string as input of of() #194

niccokunzmann opened this issue Oct 21, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Little tasks for the hacktoberfest

Comments

@niccokunzmann
Copy link
Owner

niccokunzmann commented Oct 21, 2024

This is a small but nice feature: We expect an icalendar.Calendar object as the first argument to of().
Please allow bytes and string as an input too, parsing them with icalendar.Calendar.from_ical().

To close this:

  • add the parameter types
  • parse the parameter with icalendar.Calendar.from_ical()
  • create a changelog entry
  • test your code with bytes
  • test your code with string

This would make answers like these way shorter: https://stackoverflow.com/a/79111753/1320237

@niccokunzmann niccokunzmann added enhancement New feature or request good first issue Good for newcomers hacktoberfest Little tasks for the hacktoberfest labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Little tasks for the hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant