Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft card component guidance #661

Closed
5 tasks done
davidhunter08 opened this issue Sep 30, 2020 · 3 comments · Fixed by #730
Closed
5 tasks done

Draft card component guidance #661

davidhunter08 opened this issue Sep 30, 2020 · 3 comments · Fixed by #730
Assignees
@davidhunter08
Labels
card examples guidance

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Sep 30, 2020 •
edited
Loading

What

Add guidance for the card component to the design system.

Why

The card component is being released in NHS.UK frontend v4.0.0.

Further details

The guidance is to include:

  • basic card
  • clickable card
  • card with an image
  • group of cards
  • accessibility
    -- how to change heading level
    -- how to change heading size

Done when

  • add code examples
  • draft guidance
  • add to the navigation and search index
  • content review - @sarawilcox
  • peer review
@davidhunter08 davidhunter08 self-assigned this Sep 30, 2020
@davidhunter08 davidhunter08 mentioned this issue Sep 30, 2020
Closed
@davidhunter08 davidhunter08 changed the title Add card component guidance Publish card component guidance Oct 2, 2020
@davidhunter08 davidhunter08 changed the title Publish card component guidance Draft card component guidance Oct 8, 2020
@davidhunter08 davidhunter08 mentioned this issue Oct 8, 2020
Closed
12 tasks
@davidhunter08 davidhunter08 mentioned this issue Oct 15, 2020
Merged
7 tasks
@davidhunter08 davidhunter08 linked a pull request Oct 15, 2020 that will close this issue
New components guidance (card, tag, responsive table) #730
Merged
7 tasks
@davidhunter08
Copy link
Contributor Author

@sarawilcox - examples for the card component

@davidhunter08 davidhunter08 mentioned this issue Oct 20, 2020
Closed
10 tasks
@sarawilcox
Copy link
Contributor

sarawilcox commented Oct 20, 2020 •
edited
Loading

Content reviewed. We still need to make a decision about full stops in cards as practice varies. The issue will be considered at Nov Style Council meeting: nhsuk/nhsuk-service-manual-community-backlog#272 We can publish in the meantime though.

@davidhunter08
Copy link
Contributor Author

davidhunter08 commented Oct 20, 2020 •
edited
Loading

The code examples will get added and reviewed as a part of issue 734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhunter08 davidhunter08

Labels
card examples guidance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New components guidance (card, tag, responsive table) nhsuk/nhsuk-service-manual
3 participants
@chrimesdev @davidhunter08 @sarawilcox