From 8ae35baa445488fd7b38d94074a8a5a530a41faf Mon Sep 17 00:00:00 2001 From: arturovt Date: Fri, 8 Nov 2024 22:48:17 +0200 Subject: [PATCH] chore: change to abort signal --- .../hmr-plugin/src/internal/hmr-state-context-factory.ts | 2 +- packages/store/src/internal/state-context-factory.ts | 4 ++-- packages/store/src/internal/state-factory.ts | 8 +++----- packages/store/src/symbols.ts | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/hmr-plugin/src/internal/hmr-state-context-factory.ts b/packages/hmr-plugin/src/internal/hmr-state-context-factory.ts index 580002be4..9ed9daefe 100644 --- a/packages/hmr-plugin/src/internal/hmr-state-context-factory.ts +++ b/packages/hmr-plugin/src/internal/hmr-state-context-factory.ts @@ -21,7 +21,7 @@ export class HmrStateContextFactory { */ public createStateContext(): StateContext { return { - abortController: new AbortController(), + abortSignal: new AbortController().signal, dispatch: actions => this.store!.dispatch(actions), getState: () => this.store!.snapshot(), setState: val => { diff --git a/packages/store/src/internal/state-context-factory.ts b/packages/store/src/internal/state-context-factory.ts index 733a2043f..3cc3f7a2a 100644 --- a/packages/store/src/internal/state-context-factory.ts +++ b/packages/store/src/internal/state-context-factory.ts @@ -19,11 +19,11 @@ export class StateContextFactory { /** * Create the state context */ - createStateContext(path: string, abortController?: AbortController): StateContext { + createStateContext(path: string, abortSignal?: AbortSignal): StateContext { const root = this._internalStateOperations.getRootStateOperations(); return { - abortController: abortController!, + abortSignal: abortSignal!, getState(): T { const currentAppState = root.getState(); return getState(currentAppState, path); diff --git a/packages/store/src/internal/state-factory.ts b/packages/store/src/internal/state-factory.ts index afdd01cb8..6bc77bdaf 100644 --- a/packages/store/src/internal/state-factory.ts +++ b/packages/store/src/internal/state-factory.ts @@ -347,13 +347,11 @@ export class StateFactory implements OnDestroy { for (const actionType of Object.keys(actions)) { const actionHandlers = actions[actionType].map(actionMeta => { const abortController = new AbortController(); + const abortSignal = abortController.signal; const cancellable = !!actionMeta.options.cancelUncompleted; return (action: any) => { - const stateContext = this._stateContextFactory.createStateContext( - path, - abortController - ); + const stateContext = this._stateContextFactory.createStateContext(path, abortSignal); let result = instance[actionMeta.fn](stateContext, action); @@ -394,7 +392,7 @@ export class StateFactory implements OnDestroy { result = result.pipe(takeUntil(cancelled)); } - const aborted = fromEvent(abortController.signal, 'abort'); + const aborted = fromEvent(abortSignal, 'abort'); result = result.pipe( takeUntil(aborted), diff --git a/packages/store/src/symbols.ts b/packages/store/src/symbols.ts index 3aa9bdf1b..61d461083 100644 --- a/packages/store/src/symbols.ts +++ b/packages/store/src/symbols.ts @@ -99,7 +99,7 @@ export { StateOperator }; * State context provided to the actions in the state. */ export interface StateContext { - abortController: AbortController; + abortSignal: AbortSignal; /** * Get the current state.