Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entered data is not accepted when the same value is open in two dialogs #816

Open
zevv opened this issue Jan 12, 2025 · 1 comment
Open

Comments

@zevv
Copy link

zevv commented Jan 12, 2025

Not sure if the title properly describes the issue. To reproduce:

  • Start a clean ngscopeclient
  • In the filter graph, add a Sine module. Sine_1 dialog now pops up in a new window. Leave that open.
  • Switch back to the Filter graph tab
  • Right click on the sine module and open 'Parameters' section
  • Try to enter a new value in the frequency field

The new value will not be accepted, it will be replaced with the old value as soon as the box leaves focus or when input is completed. Changing the same parameter in the initial Sine_1 popup window does work however.

@azonenberg
Copy link
Collaborator

I think the better fix for this is to not allow dual dialogs to be open, rather than trying to sync between them. Maybe auto close the dialog when you open the popup or something.

But there's also work to be done in terms of cleaning up this part of the UI. The auto spawning dialogs mostly date to the era before the filter graph editor existed. I feel like we probably don't want to open them by default now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants