-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@ngrx/signals: Add migration schematic for props #4608
Labels
Comments
If no one takes this by Saturday, I’ll work on it. |
Hello! I was taking a look at this issue and couldn't replicate it, looks like it's been resolved in the recently merged pr #4607? |
@PrajaktaB27 #4607 has implemented |
Alright, then I'd like to take that one |
rainerhahnekamp
added a commit
to rainerhahnekamp/ngrx
that referenced
this issue
Dec 1, 2024
This migration script, addressing ngrx#4608, will rename computed to props in the following scenarios: - `signalStoreFeature({computed: type<{}>())` - `signalStoreFeature(type<{computed: Signal<number>())` - `SignalStoreFeature<{computed: {}}>` - `EntityComputed` and `NamedEntityComputed`
rainerhahnekamp
added a commit
to rainerhahnekamp/ngrx
that referenced
this issue
Dec 1, 2024
This migration script applies to an update to version 19.0.0 RC 1. It addresses ngrx#4608, and will rename `computed` to `props` in the following scenarios: - `signalStoreFeature({computed: type<{}>())` - `signalStoreFeature(type<{computed: Signal<number>())` - `SignalStoreFeature<{computed: {}}>` - `EntityComputed` and `NamedEntityComputed`
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which @ngrx/* package(s) are relevant/related to the feature request?
signals
Information
Add migration schematic for
@ngrx/signals
package that covers breaking changes made in this PR: #4607EntityComputed
andNamedEntityComputed
should be renamed toEntityProps
andNamedEntityProps
:computed
should be renamed toprops
insignalStoreFeature
config:computed
should be renamed toprops
inSignalStoreFeature
generic arguments:Describe any alternatives/workarounds you're currently using
_
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: