Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post release bump version #568

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Post release bump version #568

merged 5 commits into from
Jan 15, 2025

Conversation

sofstam
Copy link
Collaborator

@sofstam sofstam commented Jan 15, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sofstam sofstam requested a review from jfy133 January 15, 2025 09:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7f5a785

+| ✅ 278 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.1
  • Run at 2025-01-15 10:00:05

@jfy133
Copy link
Member

jfy133 commented Jan 15, 2025

@nf-core-bot fix linting

@sofstam sofstam merged commit 071bcfb into dev Jan 15, 2025
26 checks passed
@sofstam sofstam deleted the bump_version_1.3.0 branch January 15, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@LilyAnderssonLee LilyAnderssonLee Awaiting requested review from LilyAnderssonLee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofstam @jfy133 @nf-core-bot