[BUG] - DropdownTrigger and PopoverTrigger pass onClick to Button causing console warning

[notthatnathan]

NextUI Version

2.6.8

Describe the bug

Button's onClick is deprecated but DropdownTrigger and maybe PopoverTrigger are passing an onClick prop to their one child, usually a Button. This causes the deprecation warning to be logged even though no direct Button instances are using onClick.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

1. Set up a dropdown with Button as trigger
2. Observe console

Expected behavior

I expect no warnings.

Screenshots or Videos

Ignore the exact error, that's because the warn assumes process and Vite doesn't surface that.

nextui/packages/utilities/shared-utils/src/console.ts

Line 11 in afe0b52

if (process.env.NODE_ENV !== "production") {

Stack shows error comes from deprecation check here:

nextui/packages/hooks/use-aria-button/src/index.ts

Line 108 in afe0b52

warn(

Operating System Version

macOS

Browser

Chrome

[linear]

ENG-1759 [BUG] - DropdownTrigger and PopoverTrigger pass onClick to Button causing console warning

[wingkwong]

For "process is not defined" issue, it has been fixed in canary and will be available in the next bug fix release.

To the original issue, another example would be using a polymorphic button. The onClick is passed from the Button component internally. We need to handle this case to avoid confusion (since users don't actually use onClick in their code).