bug: replace nullptr with MPI_COMM_NULL (#987)

TomMelt · web-flow · commit 92fe95589eb8 · 2025-11-12T12:40:28.000Z
Replace `nullptr` with `MPI_COMM_NULL` to stop failing conversion from `nullptr` to `int` Fixes #986 Thanks @docguibou for raising the issue. Please can you confirm if this fixes your compilation issue.
diff --git a/core/src/include/ModelMPI.hpp b/core/src/include/ModelMPI.hpp
@@ -27,7 +27,7 @@ class ModelMPI {
     static bool doOnce();
 
 public:
-    inline static ModelMPI& getInstance(MPI_Comm comm = nullptr)
+    inline static ModelMPI& getInstance(MPI_Comm comm = MPI_COMM_NULL)
     {
         static ModelMPI instance = ModelMPI(comm);
         if (instance.isInitialized) {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class ModelMPI {`
`27`	`27`	`static bool doOnce();`
`28`	`28`
`29`	`29`	`public:`
`30`		`- inline static ModelMPI& getInstance(MPI_Comm comm = nullptr)`
	`30`	`+ inline static ModelMPI& getInstance(MPI_Comm comm = MPI_COMM_NULL)`
`31`	`31`	`{`
`32`	`32`	`static ModelMPI instance = ModelMPI(comm);`
`33`	`33`	`if (instance.isInitialized) {`