fix: Hide download action when file does not provide download permissions #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
susnux
force-pushed
the
fix/hide-download-correctly
branch
2 times, most recently
from
eb9465a to
b6722ac
Compare
skjnldsv
approved these changes
Sep 10, 2024
juliusknorr
approved these changes
Sep 12, 2024
…ions This is not only a possibility for public shares but also for internal shares, the current code only "checked" public shares. This adds the same logic we use in the files app. Probably something to move to `@nextcloud/sharing` but for the moment lets just reuse here. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
skjnldsv
force-pushed
the
fix/hide-download-correctly
branch
from
b6722ac to
b9aac1e
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
fix/hide-download-correctly
branch
2 times, most recently
from
8f0dfcc to
4263b72
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/hide-download-correctly
branch
from
4263b72 to
86f71c2
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
fix/hide-download-correctly
branch
from
86f71c2 to
8659a4c
Compare
2 tasks
backportbot
bot
removed
the
backport-request
|
/backport to stable30 |
1 similar comment
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2482/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c78627c7 b9aac1e3 9edede18 8659a4cb
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2482/stable30Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2482/stable30."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not only a possibility for public shares but also for internal shares, the current code only "checked" public shares.
This adds the same logic we use in the files app. Probably something to move to
@nextcloud/sharingbut for the moment lets just reuse here.