Period breaks mention

[bentuna]

Tip

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Write a talk message, start typing "@..." and select something from the mention popup. The mention pill is inserted followed by a space character.
2. Hit backspace to delete the space character (needed in some cases like you want to end a sentence with the mention or want a comma directly after the mention) and add a period (".") after the mention.
3. Send the message.

Expected behaviour

In the sent message, the mention should still work and be displayed as a pill.

Actual behaviour

In the sent message, the mention is broken and not displayed as a pill anymore.

Talk app

Talk app version: 23.0.6
Nextcloud version: 32/33

[Antreesy]

Should be upstream, I guess: https://github.com/nextcloud/server/blob/255a0175233860a4399b647f345e05b005704696/lib/private/Comments/Comment.php#L216

dot / period is a valid character of user id (e.g. an email). Maybe regex can be modified to only include dots followed by other valid characters (but not whitespace). Feel free to open PR against nextcloud/server so we can discuss there

[bentuna]

dot / period is a valid character of user id (e.g. an email). Maybe regex can be modified to only include dots followed by other valid characters (but not whitespace). Feel free to open PR against nextcloud/server so we can discuss there

But I think we can determine that the period is not part of the username: when I use the autocomplete popup, the text should be rendered to This is some message with a mention "@all". so the period is outside of the "".

What happens instead is that the sent raw message text looks like that: This is some message with a mention @all.

[nickvergessen]

Should be upstream, I guess: https://github.com/nextcloud/server/blob/255a0175233860a4399b647f345e05b005704696/lib/private/Comments/Comment.php#L216

Dots are already allowed there, it's a vue lib rendering issue?

[Antreesy]

Not really, if you send mention to @user., it won't be parsed (as Comment.php regex assumes it might be an email mention to @user@mail.com

Double quotes also considered a limitation, so actually mention to @"user". would work from our side.

But then we need to wrap every mention sent (currently done only when editing) wither in Talk or upstream. Whitespace atm is intentional

[nickvergessen]

The frontend can send with " all the time.
So if there is an unrelated trailing dot and the frontend quotes the user id, it would work on the backend?

Or I mean not removing the space the frontend is adding as a workaround. but let's opt for the quotes by default. Hand written without quotes will still work manually

[Antreesy]

Probably would suffice, if modified upstream here:
https://github.com/nextcloud-libraries/nextcloud-vue/blob/e93413258d18ea6cd9e46fd590681ae619e02ccb/src/mixins/richEditor/index.js#L105-L111

to always add double quotes (additionally check for cached result in this.userData[value])
cc @ShGKme for sanity?

[ShGKme]

Always adding double quotes sounds good to me. It makes mention boundary deterministic.