Skip to content

Commit d1fbf3d

Browse files
authored
Merge pull request #59175 from rodrigocorreiaist/fix/57282-download-button-icon-color
fix(sharing): icon color mismatch on download button in public share
2 parents da70622 + 950ba3e commit d1fbf3d

157 files changed

Lines changed: 169 additions & 153 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

core/src/views/PublicPageMenu.vue

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,23 @@ function openDialogIfNeeded() {
135135
}
136136
137137
&__primary-icon {
138-
filter: var(--primary-invert-if-bright);
138+
// Light mode: icon is black by default, invert to white when primary is dark
139+
filter: var(--primary-invert-if-dark);
140+
141+
// Dark mode: icon is white (swapped in icons.css), invert to black when primary is bright
142+
@media (prefers-color-scheme: dark) {
143+
filter: var(--primary-invert-if-bright);
144+
}
139145
}
140146
}
147+
148+
// Dark theme via Nextcloud setting (data-themes attribute, not media query)
149+
:global([data-themes*=dark]) .public-page-menu__primary-icon {
150+
filter: var(--primary-invert-if-bright);
151+
}
152+
153+
// Light theme explicitly set (overrides dark media query if system is dark but user chose light)
154+
:global([data-themes*=light]) .public-page-menu__primary-icon {
155+
filter: var(--primary-invert-if-dark);
156+
}
141157
</style>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
import{a as t}from"./index-DL1yHC1K-DnBG6QLJ.chunk.mjs";import{t as e}from"./translation-DoG5ZELJ-CFYnqluG.chunk.mjs";import{C as m,a}from"./CommentView-sS3KT9Kn.chunk.mjs";import{l as p}from"./activity-CgsVnLJG.chunk.mjs";import{b as i,r as s,o as n,c,m as u}from"./Web-BwmPK40i.chunk.mjs";import{_ as l}from"./public-C1mLBHT3.chunk.mjs";import"./index-BW4M2n71.chunk.mjs";import"./NcModal-DUWLRm_F-CU-AeBE5.chunk.mjs";import"./logger-D3RVzcfQ-8mOgKmZ4.chunk.mjs";import"./createElementId-DhjFt1I9-B4kXTdvj.chunk.mjs";import"./index-B-dGqfIG.chunk.mjs";import"./TrashCanOutline-Cv7t-yKN.chunk.mjs";import"./mdi-Lt-19ASw.chunk.mjs";import"./pinia-CLibr4cC.chunk.mjs";import"./PencilOutline-CJ2aSuY5.chunk.mjs";/* empty css */import"./NcAvatar-M3-CbKbq-D3H79LgO.chunk.mjs";import"./index-BLNGy7h5.chunk.mjs";import"./util-Alk1iwuj.chunk.mjs";import"./ArrowRight-DKsMJImQ.chunk.mjs";import"./colors-BDeMBgfq-BQ_6MaUU.chunk.mjs";import"./NcUserStatusIcon-DsviB2Cr-CpKCZ3VO.chunk.mjs";import"./NcDateTime.vue_vue_type_script_setup_true_lang-BJuPH7S7-B1iF5g9H.chunk.mjs";import"./NcUserBubble-CDQa0hGy-BM5qrjQl.chunk.mjs";import"./GetComments-BEnDgTs6.chunk.mjs";import"./index-BYnFfAmz.chunk.mjs";const d=i({components:{Comment:a},mixins:[m],props:{reloadCallback:{type:Function,required:!0}},methods:{onNewComment(){try{this.reloadCallback()}catch(o){t(e("comments","Could not reload comments")),p.error("Could not reload comments",{error:o})}}}});function C(o,f,y,w,D,N){const r=s("Comment");return n(),c(r,u(o.editorData,{autoComplete:o.autoComplete,resourceType:o.resourceType,editor:!0,userData:o.userData,resourceId:o.resourceId,class:"comments-action",onNew:o.onNewComment}),null,16,["autoComplete","resourceType","userData","resourceId","onNew"])}const S=l(d,[["render",C],["__scopeId","data-v-29a1e244"]]);export{S as default};
2-
//# sourceMappingURL=ActivityCommentAction-CHAIR39m.chunk.mjs.map
1+
import{a as t}from"./index-DL1yHC1K-BJ_TsAjb.chunk.mjs";import{t as e}from"./translation-DoG5ZELJ-CFYnqluG.chunk.mjs";import{C as m,a}from"./CommentView-DhkE9b-A.chunk.mjs";import{l as p}from"./activity-CgsVnLJG.chunk.mjs";import{b as i,r as s,o as n,c,m as u}from"./Web-BwmPK40i.chunk.mjs";import{_ as l}from"./public-C1mLBHT3.chunk.mjs";import"./index-BW4M2n71.chunk.mjs";import"./NcModal-DUWLRm_F-CU-AeBE5.chunk.mjs";import"./logger-D3RVzcfQ-8mOgKmZ4.chunk.mjs";import"./createElementId-DhjFt1I9-B4kXTdvj.chunk.mjs";import"./index-B-dGqfIG.chunk.mjs";import"./TrashCanOutline-Cv7t-yKN.chunk.mjs";import"./mdi-Lt-19ASw.chunk.mjs";import"./pinia-CLibr4cC.chunk.mjs";import"./PencilOutline-CJ2aSuY5.chunk.mjs";/* empty css */import"./NcAvatar-M3-CbKbq-D3H79LgO.chunk.mjs";import"./index-BLNGy7h5.chunk.mjs";import"./util-Alk1iwuj.chunk.mjs";import"./ArrowRight-DKsMJImQ.chunk.mjs";import"./colors-BDeMBgfq-BQ_6MaUU.chunk.mjs";import"./NcUserStatusIcon-DsviB2Cr-CpKCZ3VO.chunk.mjs";import"./NcDateTime.vue_vue_type_script_setup_true_lang-BJuPH7S7-B1iF5g9H.chunk.mjs";import"./NcUserBubble-CDQa0hGy-BM5qrjQl.chunk.mjs";import"./GetComments-BEnDgTs6.chunk.mjs";import"./index-BYnFfAmz.chunk.mjs";const d=i({components:{Comment:a},mixins:[m],props:{reloadCallback:{type:Function,required:!0}},methods:{onNewComment(){try{this.reloadCallback()}catch(o){t(e("comments","Could not reload comments")),p.error("Could not reload comments",{error:o})}}}});function C(o,f,y,w,D,N){const r=s("Comment");return n(),c(r,u(o.editorData,{autoComplete:o.autoComplete,resourceType:o.resourceType,editor:!0,userData:o.userData,resourceId:o.resourceId,class:"comments-action",onNew:o.onNewComment}),null,16,["autoComplete","resourceType","userData","resourceId","onNew"])}const S=l(d,[["render",C],["__scopeId","data-v-29a1e244"]]);export{S as default};
2+
//# sourceMappingURL=ActivityCommentAction-DcqrOWtA.chunk.mjs.map
File renamed without changes.

dist/ActivityCommentAction-CHAIR39m.chunk.mjs.map renamed to dist/ActivityCommentAction-DcqrOWtA.chunk.mjs.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ActivityCommentAction-CHAIR39m.chunk.mjs.map.license renamed to dist/ActivityCommentAction-DcqrOWtA.chunk.mjs.map.license

File renamed without changes.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
import{t as s}from"./translation-DoG5ZELJ-CFYnqluG.chunk.mjs";import{C as p,a}from"./CommentView-sS3KT9Kn.chunk.mjs";import{_ as i}from"./public-C1mLBHT3.chunk.mjs";import{r as n,o as c,c as u,m as l}from"./Web-BwmPK40i.chunk.mjs";import"./index-B-dGqfIG.chunk.mjs";import"./pinia-CLibr4cC.chunk.mjs";import"./PencilOutline-CJ2aSuY5.chunk.mjs";import"./logger-D3RVzcfQ-8mOgKmZ4.chunk.mjs";import"./createElementId-DhjFt1I9-B4kXTdvj.chunk.mjs";import"./NcModal-DUWLRm_F-CU-AeBE5.chunk.mjs";/* empty css */import"./NcAvatar-M3-CbKbq-D3H79LgO.chunk.mjs";import"./index-BLNGy7h5.chunk.mjs";import"./util-Alk1iwuj.chunk.mjs";import"./ArrowRight-DKsMJImQ.chunk.mjs";import"./colors-BDeMBgfq-BQ_6MaUU.chunk.mjs";import"./NcUserStatusIcon-DsviB2Cr-CpKCZ3VO.chunk.mjs";import"./NcDateTime.vue_vue_type_script_setup_true_lang-BJuPH7S7-B1iF5g9H.chunk.mjs";import"./TrashCanOutline-Cv7t-yKN.chunk.mjs";import"./NcUserBubble-CDQa0hGy-BM5qrjQl.chunk.mjs";import"./index-DL1yHC1K-DnBG6QLJ.chunk.mjs";import"./index-BW4M2n71.chunk.mjs";import"./mdi-Lt-19ASw.chunk.mjs";import"./activity-CgsVnLJG.chunk.mjs";import"./GetComments-BEnDgTs6.chunk.mjs";import"./index-BYnFfAmz.chunk.mjs";const d={name:"ActivityCommentEntry",components:{Comment:a},mixins:[p],props:{comment:{type:Object,required:!0},reloadCallback:{type:Function,required:!0}},data(){return{commentMessage:""}},watch:{comment(){this.commentMessage=this.comment.props.message}},mounted(){this.commentMessage=this.comment.props.message},methods:{t:s}};function g(t,e,o,f,m,C){const r=n("Comment");return c(),u(r,l({ref:"comment",tag:"li"},o.comment.props,{autoComplete:t.autoComplete,resourceType:t.resourceType,message:m.commentMessage,resourceId:t.resourceId,userData:t.genMentionsData(o.comment.props.mentions),class:"comments-activity",onDelete:e[0]||(e[0]=y=>o.reloadCallback())}),null,16,["autoComplete","resourceType","message","resourceId","userData"])}const Q=i(d,[["render",g],["__scopeId","data-v-afc310f1"]]);export{Q as default};
2-
//# sourceMappingURL=ActivityCommentEntry-BbbT2NBb.chunk.mjs.map
1+
import{t as s}from"./translation-DoG5ZELJ-CFYnqluG.chunk.mjs";import{C as p,a}from"./CommentView-DhkE9b-A.chunk.mjs";import{_ as i}from"./public-C1mLBHT3.chunk.mjs";import{r as n,o as c,c as u,m as l}from"./Web-BwmPK40i.chunk.mjs";import"./index-B-dGqfIG.chunk.mjs";import"./pinia-CLibr4cC.chunk.mjs";import"./PencilOutline-CJ2aSuY5.chunk.mjs";import"./logger-D3RVzcfQ-8mOgKmZ4.chunk.mjs";import"./createElementId-DhjFt1I9-B4kXTdvj.chunk.mjs";import"./NcModal-DUWLRm_F-CU-AeBE5.chunk.mjs";/* empty css */import"./NcAvatar-M3-CbKbq-D3H79LgO.chunk.mjs";import"./index-BLNGy7h5.chunk.mjs";import"./util-Alk1iwuj.chunk.mjs";import"./ArrowRight-DKsMJImQ.chunk.mjs";import"./colors-BDeMBgfq-BQ_6MaUU.chunk.mjs";import"./NcUserStatusIcon-DsviB2Cr-CpKCZ3VO.chunk.mjs";import"./NcDateTime.vue_vue_type_script_setup_true_lang-BJuPH7S7-B1iF5g9H.chunk.mjs";import"./TrashCanOutline-Cv7t-yKN.chunk.mjs";import"./NcUserBubble-CDQa0hGy-BM5qrjQl.chunk.mjs";import"./index-DL1yHC1K-BJ_TsAjb.chunk.mjs";import"./index-BW4M2n71.chunk.mjs";import"./mdi-Lt-19ASw.chunk.mjs";import"./activity-CgsVnLJG.chunk.mjs";import"./GetComments-BEnDgTs6.chunk.mjs";import"./index-BYnFfAmz.chunk.mjs";const d={name:"ActivityCommentEntry",components:{Comment:a},mixins:[p],props:{comment:{type:Object,required:!0},reloadCallback:{type:Function,required:!0}},data(){return{commentMessage:""}},watch:{comment(){this.commentMessage=this.comment.props.message}},mounted(){this.commentMessage=this.comment.props.message},methods:{t:s}};function g(t,e,o,f,m,C){const r=n("Comment");return c(),u(r,l({ref:"comment",tag:"li"},o.comment.props,{autoComplete:t.autoComplete,resourceType:t.resourceType,message:m.commentMessage,resourceId:t.resourceId,userData:t.genMentionsData(o.comment.props.mentions),class:"comments-activity",onDelete:e[0]||(e[0]=y=>o.reloadCallback())}),null,16,["autoComplete","resourceType","message","resourceId","userData"])}const Q=i(d,[["render",g],["__scopeId","data-v-afc310f1"]]);export{Q as default};
2+
//# sourceMappingURL=ActivityCommentEntry-BCZMrASQ.chunk.mjs.map
File renamed without changes.

dist/ActivityCommentEntry-BbbT2NBb.chunk.mjs.map renamed to dist/ActivityCommentEntry-BCZMrASQ.chunk.mjs.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ActivityCommentEntry-BbbT2NBb.chunk.mjs.map.license renamed to dist/ActivityCommentEntry-BCZMrASQ.chunk.mjs.map.license

File renamed without changes.

0 commit comments

Comments
 (0)