Skip to content

Commit 98d25c3

Browse files
kra-moAndyScherzinger
authored andcommitted
fix(AppMenuActions): Shorten "More actions" label
Partly to avoid awkward wrapping Signed-off-by: kramo <git@kramo.page>
1 parent 4003136 commit 98d25c3

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

core/src/components/AppMenuActions.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const emit = defineEmits<{
2828
2929
/**
3030
* Number of cells in the actions row, matching the column count of the app
31-
* grid. Actions that do not fit move into the trailing "More actions" cell.
31+
* grid. Actions that do not fit move into the trailing "More" cell.
3232
*/
3333
const ACTIONS_PER_ROW = 4
3434
@@ -42,7 +42,7 @@ const overflowEntry: INavigationEntry = {
4242
href: '',
4343
icon: '',
4444
type: 'action',
45-
name: t('core', 'More actions'),
45+
name: t('core', 'More'),
4646
unread: 0,
4747
}
4848

core/src/tests/components/AppMenu.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,15 +592,15 @@ describe('core: AppMenu navigation actions', () => {
592592
expect(document.activeElement).toBe(rowItems()[0])
593593
})
594594

595-
it('moves the actions that do not fit into a "More actions" submenu', async () => {
595+
it('moves the actions that do not fit into a "More" submenu', async () => {
596596
initialState.loadState.mockImplementation(stateWith(fakeApps(), fakeActions(6)))
597597
const wrapper = mount(AppMenu, { attachTo: document.body })
598598
await openPopover(wrapper)
599599

600600
const items = rowItems()
601601
// Three actions plus the trailing overflow item make up the single row.
602602
expect(items).toHaveLength(4)
603-
expect(items[3].textContent).toContain('More actions')
603+
expect(items[3].textContent).toContain('More')
604604
expect(items[3].getAttribute('aria-haspopup')).toBe('menu')
605605
expect(items[3].getAttribute('aria-expanded')).toBe('false')
606606
expect(document.querySelector('.app-menu-actions__submenu')).toBeNull()

0 commit comments

Comments
 (0)